Retrigger Travis build for debugging #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way developers will see any potential missing context without running the entire filter, which may not ever encounter a case where it needs the context.
Declaring required contexts has been simplified. validates_context_presence no longer requires self to be passed in. Instead it will attempt to build the caller name by using Kernel::caller. Tests have been added for filters that require context.
Noted in filters if a context is required. Updated README to include info about required contexts.
Using a singleton to remove the reliance on a class variable. Removed unnecessary calling_class method and just using self instead.
This way developers will see any potential missing context without running the entire filter, which may not ever encounter a case where it needs the context.
Declaring required contexts has been simplified. validates_context_presence no longer requires self to be passed in. Instead it will attempt to build the caller name by using Kernel::caller. Tests have been added for filters that require context.
Noted in filters if a context is required. Updated README to include info about required contexts.
Using a singleton to remove the reliance on a class variable. Removed unnecessary calling_class method and just using self instead.
…-pipeline into context_validation
Removed declarative code in favor of a validation hook. It's up to subclasses to implement the validate method. Validate will be called by Filter after initialization so @context is available. Reverted README.md to remove the additions about validation.
Changed required context method name to 'needs.' Updated needs to use @jbarnette's concise version of needs. Made validate a noop method instead of checking if a filter respond_to? validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.