Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Drop support for EOL Python 3.7" #52

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

EliahKagan
Copy link
Contributor

@EliahKagan EliahKagan commented Sep 17, 2023

Analogous to gitpython-developers/gitdb#94, this brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7), even though 3.7 is end of life, because support for 3.7 is not being dropped by GitPython (or gitdb) yet, and there is value in keeping GitPython, gitdb, and smmap consistent.

This reverts commit f1b4d14.


Discussion relevant to determining whether this should be merged, as well as whether a new release should be made after doing so if it is, begins at #51 (comment).

Analogous to gitpython-developers/gitdb#94,
this brings back Python 3.7 support (allowing it to be installed on
3.7, and testing on 3.7), even though 3.7 is end of life, because
support for 3.7 is not being dropped by GitPython (or gitdb) yet,
and there is value in keeping GitPython, gitdb, and smmap
consistent.

This reverts commit f1b4d14.
@EliahKagan EliahKagan marked this pull request as ready for review September 17, 2023 08:52
@Byron Byron merged commit 156151c into gitpython-developers:master Sep 17, 2023
6 checks passed
@Byron
Copy link
Member

Byron commented Sep 17, 2023

Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants