Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Drop support for EOL Python 3.7" #94

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

EliahKagan
Copy link
Contributor

@EliahKagan EliahKagan commented Sep 11, 2023

This brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7 on CI), even though 3.7 is end-of-life. The reason is that support for 3.7 is not being dropped by GitPython yet, and there is value in keeping the version ranges supported by GitPython and gitdb consistent. This is noted in review comments on gitpython-developers/GitPython#1654.

This reverts commit 875acb4.

This brings back Python 3.7 support (allowing it to be installed on
3.7, and testing on 3.7 on CI), even though 3.7 is end-of-life,
because support for 3.7 is not being dropped by GitPython yet, and
there is value in keeping the version ranges supported by GitPython
and gitdb consistent.

This reverts commit 875acb4.
@EliahKagan EliahKagan marked this pull request as ready for review September 11, 2023 09:23
@Byron Byron merged commit d24f019 into gitpython-developers:master Sep 11, 2023
6 checks passed
@Byron
Copy link
Member

Byron commented Sep 11, 2023

Perfect, thank you!

@EliahKagan EliahKagan deleted the py37 branch September 11, 2023 09:30
EliahKagan added a commit to EliahKagan/smmap that referenced this pull request Sep 17, 2023
Analogous to gitpython-developers/gitdb#94,
this brings back Python 3.7 support (allowing it to be installed on
3.7, and testing on 3.7), even though 3.7 is end of life, because
support for 3.7 is not being dropped by GitPython (or gitdb) yet,
and there is value in keeping GitPython, gitdb, and smmap
consistent.

This reverts commit f1b4d14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants