Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change also "pluginSinceBuild" property when updating JetBrains Plugins via GitHub Action #13904

Merged
merged 1 commit into from
Oct 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ jobs:
- name: Update ${{ inputs.gradlePropertiesPath }}
if: ${{ steps.latest-version.outputs.result != steps.current-version.outputs.result }}
run: |
PLUGIN_SINCE_BUILD=$(echo "${{ steps.latest-version.outputs.result }}" | sed 's/-EAP-CANDIDATE-SNAPSHOT//' | sed 's/-CUSTOM-SNAPSHOT//')
sed -i "s/pluginSinceBuild=.*/pluginSinceBuild=$PLUGIN_SINCE_BUILD/" ${{ inputs.gradlePropertiesPath }}
sed -i 's/platformVersion=${{ steps.current-version.outputs.result }}/platformVersion=${{ steps.latest-version.outputs.result }}/' ${{ inputs.gradlePropertiesPath }}
git diff
- name: Create Pull Request for Gateway Plugin
Expand Down Expand Up @@ -90,7 +92,8 @@ jobs:
commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}"
branch: "jetbrains/${{ inputs.pluginId }}-platform"
labels: "team: IDE,editor: jetbrains"
team-reviewers: "engineering-ide"
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
# team-reviewers: "engineering-ide"
- name: Create Pull Request for Backend Plugin
if: ${{ inputs.pluginId == 'backend-plugin' && steps.latest-version.outputs.result != steps.current-version.outputs.result }}
uses: peter-evans/create-pull-request@v4
Expand Down Expand Up @@ -119,14 +122,15 @@ jobs:
commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}"
branch: "jetbrains/${{ inputs.pluginId }}-platform"
labels: "team: IDE"
team-reviewers: "engineering-ide"
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
# team-reviewers: "engineering-ide"
- name: Get previous job's status
id: lastrun
uses: filiptronicek/get-last-job-status@main
- name: Slack Notification
if: ${{ (success() && steps.lastrun.outputs.status == 'failed') || failure() }}
uses: rtCamp/action-slack-notify@v2
env:
SLACK_WEBHOOK: ${{ secrets.slackWebhook }}
SLACK_COLOR: ${{ job.status }}
SLACK_TITLE: ${{ inputs.productName }}
SLACK_WEBHOOK: ${{ secrets.slackWebhook }}
SLACK_COLOR: ${{ job.status }}
SLACK_TITLE: ${{ inputs.productName }}
3 changes: 2 additions & 1 deletion .github/workflows/jetbrains-updates-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ jobs:
commit-message: "[${{ inputs.productId }}] Update IDE image to build version ${{ steps.latest-release.outputs.version }}"
branch: "jetbrains/${{ inputs.productId }}-${{ steps.latest-release.outputs.version2 }}"
labels: "team: IDE,editor: jetbrains"
team-reviewers: "engineering-ide"
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
# team-reviewers: "engineering-ide"
- name: Get previous job's status
id: lastrun
uses: filiptronicek/get-last-job-status@main
Expand Down