Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change also "pluginSinceBuild" property when updating JetBrains Plugins via GitHub Action #13904

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Oct 17, 2022

Description

This PR brings two changes:

  • Change also the pluginSinceBuild Gradle property when updating JetBrains Plugins via GitHub Action. Previously, we were updating only the platformVersion which could cause incompatibilities with old JetBrains Gateway versions.
  • Comment out the line team-reviewers: "engineering-ide", to avoid the action failing (when it's actually creating the Pull Request properly). (See Pull Requests created by GitHub Actions are not correctly assigning reviewers #12194)
    Screenshot from the error on slack when team-reviewers: "engineering-ide" is set
    image

How to test

Optional: Click "Run Workflow" (targeting the jetbrains/update-also-plugin-since-build-property branch) on JB Plugins Platform Update action page to create PRs.
image

I've already run it, and you can see the Diff result here.
image
So when it creates the PR, this is what the reviewer will see:
image

Release Notes

NONE

@felladrin felladrin force-pushed the jetbrains/update-also-plugin-since-build-property branch from 3ef23b4 to 031cfab Compare October 17, 2022 11:55
@felladrin felladrin changed the title Update GitHub action to change also the "pluginSinceBuild" Gradle property when updating JetBrains Plugins via GitHub Action Change also the "pluginSinceBuild" Gradle property when updating JetBrains Plugins via GitHub Action Oct 18, 2022
@felladrin felladrin changed the title Change also the "pluginSinceBuild" Gradle property when updating JetBrains Plugins via GitHub Action Change also "pluginSinceBuild" property when updating JetBrains Plugins via GitHub Action Oct 18, 2022
@roboquat roboquat merged commit ad932eb into main Oct 18, 2022
@roboquat roboquat deleted the jetbrains/update-also-plugin-since-build-property branch October 18, 2022 13:02
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants