Change also "pluginSinceBuild" property when updating JetBrains Plugins via GitHub Action #13904
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
requested review from
a team
and removed request for
andreafalzetti
felladrin
force-pushed
the
jetbrains/update-also-plugin-since-build-property
branch
2 times, most recently
from
982be3e
to
3ef23b4
Compare
This was referenced Oct 17, 2022
…rains Plugins via GitHub Action
felladrin
force-pushed
the
jetbrains/update-also-plugin-since-build-property
branch
from
3ef23b4
to
031cfab
Compare
This was referenced Oct 17, 2022
felladrin
changed the title
felladrin
changed the title
This was referenced Oct 18, 2022
andreafalzetti
approved these changes
Oct 18, 2022
roboquat
deleted the
jetbrains/update-also-plugin-since-build-property
branch
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings two changes:
pluginSinceBuildGradle property when updating JetBrains Plugins via GitHub Action. Previously, we were updating only theplatformVersionwhich could cause incompatibilities with old JetBrains Gateway versions.team-reviewers: "engineering-ide", to avoid the action failing (when it's actually creating the Pull Request properly). (See Pull Requests created by GitHub Actions are not correctly assigning reviewers #12194)team-reviewers: "engineering-ide"is setHow to test
Optional: Click "Run Workflow" (targeting the
jetbrains/update-also-plugin-since-build-propertybranch) on JB Plugins Platform Update action page to create PRs.I've already run it, and you can see the Diff result here.
So when it creates the PR, this is what the reviewer will see:
Release Notes