Skip to content

Fix usage of install_macos.sh in README #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zanieb wants to merge 1 commit into from
Closed

Fix usage of install_macos.sh in README #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ You can manually drag the fonts from the `fonts/otf` or `fonts/variable` directo
There is also a script that automates the deletion of all Monaspace fonts from `~/Library/Fonts` and then copies over the latest versions. Invoke it from the root of the repo like:

```bash
$ cd util
$ bash ./install_macos.sh
$ bash ./util/install_macos.sh
Copy link

@trag1c trag1c Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ bash ./util/install_macos.sh
$ bash util/install_macos.sh

Copy link
Author

@zanieb zanieb Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain your suggestion? Being explicit about using the current directory is clearer and consistent with the existing style i.e. with this change it would not match the Linux installation instructions.

Copy link

@trag1c trag1c Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being explicit about using the current directory is clearer

I personally find NOT specifying the current directory clearer ¯\_(ツ)_/¯ there's a tiny bit less stuff to parse by our brains

consistent with the existing style i.e. with this change it would not match the Linux installation instructions

didn't notice 😄 in that case I'd personally also remove it from Linux installation instructions; I simply find it unnecessary as bash install_linux.sh already tells me the file is in the cwd :)

I'm fine with it being bash ./util/install_macos.sh though, it's really just a nit

```
You can also use [homebrew](https://brew.sh/) as an alternative:

Expand Down