Fix usage of install_macos.sh in README
#71
Conversation
The provided suggestion to run `./install_macos.sh` from the `util` directory fails since the script expects to be relative to the root of the content. ``` ❯ cd util ❯ bash ./install_macos.sh cp: ./fonts/otf/*: No such file or directory cp: ./fonts/variable/*: No such file or directory ``` Avoiding the change to `util` and running `bash ./util/install_macos.sh` works.
|
Excellent PR. |
|
Someone fixed the Linux instructions in #104 — there are already a bunch of duplicates so I'll just leave it separate. |
| ```bash | ||
| $ cd util | ||
| $ bash ./install_macos.sh | ||
| $ bash ./util/install_macos.sh |
There was a problem hiding this comment.
| $ bash ./util/install_macos.sh | |
| $ bash util/install_macos.sh |
There was a problem hiding this comment.
Can you explain your suggestion? Being explicit about using the current directory is clearer and consistent with the existing style i.e. with this change it would not match the Linux installation instructions.
There was a problem hiding this comment.
Being explicit about using the current directory is clearer
I personally find NOT specifying the current directory clearer ¯\_(ツ)_/¯ there's a tiny bit less stuff to parse by our brains
consistent with the existing style i.e. with this change it would not match the Linux installation instructions
didn't notice 😄 in that case I'd personally also remove it from Linux installation instructions; I simply find it unnecessary as bash install_linux.sh already tells me the file is in the cwd :)
I'm fine with it being bash ./util/install_macos.sh though, it's really just a nit
|
Fixed in the batch of commits around 93c4bcd. Thank you! |
6 participants
The provided suggestion to run
./install_macos.shfrom theutildirectory fails since the script expects to be relative to the
root of the content.
Avoiding the change to
utiland runningbash ./util/install_macos.shworks.
A similar pull request exists for the Linux installation instructions at #104