Consider Composer dev dependencies #486
Conversation
There was a problem hiding this comment.
🚀 ✨ thanks for opening this PR! One small suggestion to keep ruby style consistency, and can you update the composer fixtures and add a test case that exercises the new config option? Let me know if any of how to make that work is unclear!
As I am not sure about the BC policy of this library, I made this a configuration option, so that people do not automatically get all the license updates. In general I would consider this enabled by default though, wdyt?
Dev or test dependencies do not normally ship with a product, so are not normally a primary concern where OSS compliance is involved. I think leaving the default to false and making this opt-in like the solution in this PR is the best strategy 👍
|
Thanks for the quick feedback! I guess I was just happy to get the code working and forgot about testing 😅 |
digilist
force-pushed
the
composer_dev_dependencies
branch
from
d84231b
to
40be0ff
Compare
There was a problem hiding this comment.
🚀 looks great, thanks! I'm putting out a release for licensed later today so this should be available for use relatively soon 👍
I'm going to ignore the license metadata verification failure, the issue is related to the running the workflow and not anything specific to the code changed here.
|
Thank you very much! 👍 |
## 3.6.0 2022-03-17 ### Added - Composer dev dependencies can optionally be included in enumerated PHP dependencies (:tada: `@digilist` #486) - Getting started usage documentation (#483) - Initial support for NPM workspaces (#485) ### Changed - Transitive dependencies are now enumerated by the `pip` source (#480) ### Fixed - `licensed cache --force` will now correctly overwrite existing license classifications (#473)
I noticed that composer dev dependencies haven't been considered by this package, so I wanted to add this.
As I am not sure about the BC policy of this library, I made this a configuration option, so that people do not automatically get all the license updates. In general I would consider this enabled by default though, wdyt?