Use pip list to get packages for pip source #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also removes the need for a requirements.txt file in the current directory
|
The Please review the pull request for any additional changes required and merge when ready. |
it looks like the one I used before might have been a dependency of an older pip version that's no longer present in the version used in CI
License updates for pip-fixes
jonabc
added a commit
that referenced
this pull request
Mar 17, 2022
## 3.6.0 2022-03-17 ### Added - Composer dev dependencies can optionally be included in enumerated PHP dependencies (:tada: `@digilist` #486) - Getting started usage documentation (#483) - Initial support for NPM workspaces (#485) ### Changed - Transitive dependencies are now enumerated by the `pip` source (#480) ### Fixed - `licensed cache --force` will now correctly overwrite existing license classifications (#473)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the pip source to gather dependencies from
pip listrather than parsingrequirements.txt. This is done to accommodate the multitude of requirement specifies that weren't currently being handled, such as direct file specifiers. Instead licensed now relies on pip to report what dependencies are being used. As a side effect, this now causes the pip source to report on transitive/nested dependencies, where previously only explicit dependencies were being reported 🤦After all dependencies were being reported, I found that performance was really suffering because many more
pip showcommands were being executed. Thankfully thoughpip showsupports entering multiple package names in one command, which overall made the source faster than it was before this PR 🚀 .Some minor side effects of this change
requirements.txtfile. we just need to know the virtual env directory to run under and pip gives us all the rest of the information.