Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed class theme in language toggle to use the base active #5765

Merged
merged 4 commits into from
May 1, 2021

Conversation

Xenolithes
Copy link
Contributor

@Xenolithes Xenolithes commented Apr 27, 2021

instead of link--secondary when selected

Why:

Changes the active theme from Link.secondary to just active

Closes #268

What's being changed:

Before:
Japanese Example:
Screen Shot 2021-04-27 at 10 31 52 AM
English Example:
Screen Shot 2021-04-27 at 10 30 49 AM

After:
Japanese Example:

Screen Shot 2021-04-27 at 9 03 23 AM

English Example:
Screen Shot 2021-04-27 at 9 03 36 AM

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

@Xenolithes Xenolithes requested a review from a team as a code owner April 27, 2021 14:41
@welcome
Copy link

welcome bot commented Apr 27, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2021
@janiceilene
Copy link
Contributor

@Xenolithes Thanks so much for opening a PR with this fix! I'll get this triaged for review ⚡

I slightly edited your OP to remove the [ ] from around the issue link. Now the issue and PR are linked, so that when the PR is merged, the issue will close automatically ✨

@janiceilene janiceilene added engineering Will involve Docs Engineering waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 28, 2021
@rachmari rachmari enabled auto-merge (squash) May 1, 2021 00:40
@rachmari rachmari merged commit d39e9b3 into github:main May 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Octomerger added a commit that referenced this pull request May 1, 2021
…stead of link--secondary when selected (#5765) (#19103)

Co-authored-by: Evan Schweitzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX: Navbar active link's styling for all section should be same for better user experience
4 participants