Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/UX: Navbar active link's styling for all section should be same for better user experience #268

Closed
dwarcash opened this issue Oct 8, 2020 · 5 comments · Fixed by #5765
Closed

UI/UX: Navbar active link's styling for all section should be same for better user experience #268

dwarcash opened this issue Oct 8, 2020 · 5 comments · Fixed by #5765
Labels
engineering Will involve Docs Engineering good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@dwarcash
Copy link

dwarcash commented Oct 8, 2020 •
edited
Loading

What is the current behavior?

👉 Opening navbar, in language selector, selected language as active link styling is not same as the version selector's

👉 In mobile site, selected language in drop down is not much visible as the selected one

Screenshot 2020-10-08 190922
Screenshot 2020-10-08 192407
Screenshot 2020-10-08 190857

What changes are you suggesting?

👉 For better User Experience, active links should be same on both sections

👉 In mobile view, setting active language styling same as version section has a better user experience

Screenshot 2020-10-08 195605
Screenshot 2020-10-08 195652

Additional information
No additional information
@dwarcash dwarcash added the engineering Will involve Docs Engineering label Oct 8, 2020
@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 8, 2020
@dwarcash dwarcash changed the title UI/UX: Navbar active links for all section should be same for better user experience UI/UX: Navbar active link's styling for all section should be same for better user experience Oct 8, 2020
@janiceilene janiceilene reopened this Oct 8, 2020
@janiceilene
Copy link
Contributor

Thanks for opening an issue @dwarcash! I'll triage this for @github/docs-engineering to respond 🌟

@janiceilene janiceilene removed the triage Do not begin working on this issue until triaged by the team label Oct 8, 2020
@dwarcash
Copy link
Author

dwarcash commented Oct 9, 2020

Thanks for reopening @janiceilene !

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 7, 2021
@Anmar1988260 Anmar1988260 mentioned this issue Feb 9, 2021
Open
@montana910318 montana910318 mentioned this issue Feb 9, 2021
Open
@chiedo chiedo added help wanted Anyone is welcome to open a pull request to fix this issue good first issue Good for newcomers and removed stale There is no recent activity on this issue or pull request labels Feb 23, 2021
@YoYBaBy YoYBaBy mentioned this issue Mar 2, 2021
Open
This was referenced Mar 9, 2021
Open
Open
@ramsemune ramsemune mentioned this issue Mar 11, 2021
Merged
@Dmarch28 Dmarch28 mentioned this issue Mar 11, 2021
Open
@YoYBaBy YoYBaBy mentioned this issue Mar 14, 2021
Open
@snyk-bot snyk-bot mentioned this issue Mar 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Apr 2, 2021
Open
This was referenced Apr 9, 2021
Open
Open
This was referenced Apr 20, 2021
Open
Open
Open
@Xenolithes Xenolithes mentioned this issue Apr 27, 2021
Merged
6 tasks
@snyk-bot snyk-bot mentioned this issue Apr 27, 2021
Open
Xenolithes added a commit to Xenolithes/docs that referenced this issue Apr 30, 2021
@Xenolithes
Merge branch 'main' into github#268-active-language-display
8ca48a4
rachmari added a commit to Xenolithes/docs that referenced this issue May 1, 2021
@rachmari
Merge branch 'main' into github#268-active-language-display
c23cb8c
rachmari added a commit to Xenolithes/docs that referenced this issue May 1, 2021
@rachmari
Merge branch 'main' into github#268-active-language-display
410c059
This was referenced May 4, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue May 27, 2021
Open
This was referenced Jun 6, 2021
Open
Open
Open
This was referenced Jun 14, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 24, 2021
Open
This was referenced Jul 5, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 29, 2021
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
@mirandaauhl
update sql and python scripts to work properly (github#268)
f01c944 
Co-authored-by: Miranda Auhl <[email protected]>
@Woodpile37 Woodpile37 mentioned this issue Aug 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering Will involve Docs Engineering good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed class theme in language toggle to use the base active Xenolithes/docs
3 participants
@chiedo @janiceilene @dwarcash