Clarify access level needed for secrets in web interface

[muru]

Why:

Closes #1087

What's being changed:

I changed the initial text of "Creating encrypted secrets for a repository" and also added a note at the end of that section:

• Including a mention of "web interface" lead to (IMO) too much duplication in text, so I rephrased it to be more like the permissions-statement-secrets-api reusable.

• I considered changing the permissions-statement-secrets-repository reusable to include a reference to the API, but then I noticed that the other place using it ("Enabling debug logging") already mentioned the API, so instead I added a note.

• Screenshot of "Creating encrypted secrets for a repository", with the unchanged parts snipped:

  

• Screenshot of "Enabling debug logging":

  

Check off the following:

• I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
• For content changes, I have reviewed the localization checklist
• For content changes, I have reviewed the Content style guide for GitHub Docs.
  • The style guide says "do not include [...] permissions," however I feel that this note might be acceptable as "useful information or reminders for the user" since it describes a relaxation in permissions compared to the preceding text.

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[janiceilene]

Thanks so much for opening a PR @muru! I'll get this triaged for the team to take a look when they're back from the holidays 💖

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[janiceilene]

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[muru]

Is the closure intentional? Should I amend the PR?

[janiceilene]

I'm so sorry about that @muru! No amendments needed. It looks like our new action inadvertently closed this 🙃 Reopening and triaging this for review 💛

[hubwriter]

@muru - Many thanks for raising this PR.

I like the note that you added, with the link to the secrets API page, that's useful, thanks.

I think we should stick with the current reusable text. IMO it makes a clearer distinction between what you need to create a secret for a user account repo and what you need to create a secret for an organization repo.

[hubwriter]

@muru - As this PR has been waiting for our attention for so long I'm going to go ahead and merge the modified version (without the change to the reusable text).

Many thanks again for taking the time to help improve our docs. It's much appreciated. 👍

Of course if you disagree with my comments please get back in touch.
All the best.

[muru]

@hubwriter that's fine by me! Thanks for reviewing!