Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to Github Actions #3302

Closed
abitmore opened this issue Nov 20, 2020 · 13 comments
Closed

Migrate from Travis CI to Github Actions #3302

abitmore opened this issue Nov 20, 2020 · 13 comments

Comments

@abitmore
Copy link
Member

Travis-CI.org will be shut down on December 31, 2020. Full details are in this newsletter from Travis.

Now is the time to migrate to Travis-CI.com.

Instructions for migrating to Travis-CI.com are available in the Travis documentation on repository migration.

In addition to migrating the repository to Travis-CI.com, please remember to also update the Travis status badges in the README.md files, make sure that all of the README.md files are using the Travis-CI.com badges. More information on Travis status badges is available in the Travis documentation page on status images.

Reference: https://discourse.julialang.org/t/reminder-travis-ci-org-shuts-down-on-december-31-2020/47234

@sschiessl-bcp
Copy link
Contributor

I'd suggest to migrate to GitHub actions if anything

@abitmore
Copy link
Member Author

I do agree that Github Actions is good to have though. Anyway migration from travis-ci.org to travis-ci.com is just a few clicks.

@abitmore
Copy link
Member Author

It seems the .com free plan is not suitable for us. See https://travis-ci.com/organizations/bitshares/plan

Builds have been temporarily disabled for private and public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance.

@abitmore
Copy link
Member Author

It is possible to get more credits, but I'm not sure how much work is needed (and I'm not going to try):

We will be offering an allotment of OSS minutes that will be reviewed and allocated on a case by case basis. Should you want to apply for these credits please open a request with Travis CI support stating that you’d like to be considered for the OSS allotment. Please include:

  • Your account name and VCS provider How many credits (build minutes) you’d like to request (should your run out of credits again you can repeat the process to request more or discuss a renewable amount)

@abitmore abitmore changed the title Migrate Travis CI from Travis-CI.org to Travis-CI.com Migrate from Travis CI to Github Actions Jan 24, 2021
@abitmore
Copy link
Member Author

This is mostly done for develop branch. The latest PR was #3326.

By viewing the deployment history, https://github.com/bitshares/develop.bitshares.org/commits/master, we can see that Travis CI deployed again after Github Actions deployed.

I noticed there are some differences between the Travis CI flow and the Github Actions flow, see bitshares/develop.bitshares.org@a640623,

  • deposit-withdraw/index.html is in the Travis flow but not in the Github Actions flow;
  • a line of code <base href="/"> in index.html is in the Github Actions flow but not in Travis.

@sschiessl-bcp
Copy link
Contributor

The deposit-withdraw file is used by blocktrades.

When we have a staging version this should be tested.

abitmore added a commit that referenced this issue Feb 18, 2021
to fix the deposit-withdraw page missing issue (#3302 (comment))
@abitmore
Copy link
Member Author

New PR: #3338

@abitmore
Copy link
Member Author

abitmore commented Feb 18, 2021

BTW it seems we're not pushing to staging.bitshares.org via Github Actions.

Update: please check #3339

@sschiessl-bcp
Copy link
Contributor

Staging and master is next. Need to transfer the release bundling flow.

@abitmore
Copy link
Member Author

Deploy key for staging is now active.

FWIW I added a deploy key to the wallet.bitshares.org repository but removed it later, because I thought there could be security issues -- according to github/docs#2330, all user with write access to this repository is able to use the secrets via REST API thus is able to update the target repository. Any idea how to automate more safely?

@abitmore
Copy link
Member Author

deploy key ... security issues ...

It seems the "environments" feature would fit our needs, see https://docs.github.com/en/actions/reference/environments

You can configure environments with protection rules and secrets. A workflow job can reference an environment to use the environment's protection rules and secrets.

When a workflow job references an environment, the job won't start until all of the environment's protection rules pass. A job also cannot access secrets that are defined in an environment until all the environment protection rules pass.

@sschiessl-bcp
Copy link
Contributor

@abitmore
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants