Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull requests from #22729

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Add pull requests from #22729

merged 2 commits into from
Dec 16, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 16, 2022

Why:

Closes #22492

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds pull requests from

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 16, 2022
@cmwilson21
Copy link
Contributor

👋 Hey @jsoref - Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Dec 16, 2022
sabrowning1
sabrowning1 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for another contribution @jsoref! I'll merge this shortly 👍🏼

@sabrowning1 sabrowning1 merged commit 774b006 into github:main Dec 16, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@sabrowning1 sabrowning1 removed the waiting for review Issue/PR is waiting for a writer's review label Dec 16, 2022
@jsoref jsoref deleted the issue-22492 branch December 16, 2022 18:51
@ghost

This comment was marked as spam.

Sign in to view
@Githubant123

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrowning1 sabrowning1 sabrowning1 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team repositories Content related to repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

has read-only permissions in forked repositories is incorrect
4 participants
@jsoref @cmwilson21 @Githubant123 @sabrowning1