Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has read-only permissions in forked repositories is incorrect #22492

Closed
1 task done
jsoref opened this issue Dec 6, 2022 · 2 comments · Fixed by #22729
Closed
1 task done

has read-only permissions in forked repositories is incorrect #22492

jsoref opened this issue Dec 6, 2022 · 2 comments · Fixed by #22729
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue repositories Content related to repositories

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 6, 2022

Code of Conduct

What article on docs.github.com is affected?

docs/data/reusables/developer-site/pull_request_forked_repos_link.md

Line 5 in 6d25c89

{% data reusables.actions.forked-secrets %} The `GITHUB_TOKEN` has read-only permissions in forked repositories. For more information, see "[Authenticating with the GITHUB_TOKEN](/actions/configuring-and-managing-workflows/authenticating-with-the-github_token)."

What part(s) of the article would you like to see updated?

The part that says:

has read-only permissions in forked repositories.

It should probably say

has read-only permissions in pull requests from forked repositories.

Additional information

PowerDNS/pdns#12249 (comment)
@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Dec 6, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 6, 2022
@jsoref jsoref mentioned this issue Dec 6, 2022
Closed
1 task
@cmwilson21
Copy link
Contributor

👋 Hey @jsoref - Thanks for opening an issue! I'll get it triaged for review ✨

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Dec 7, 2022
@lucascosti
Copy link
Contributor

👋 Yep, the suggested change sounds good. Anyone can feel free to open a PR to fix.

@lucascosti lucascosti added the help wanted Anyone is welcome to open a pull request to fix this issue label Dec 16, 2022
@jsoref jsoref mentioned this issue Dec 16, 2022
Merged
2 tasks
@cmwilson21 cmwilson21 removed the waiting for review Issue/PR is waiting for a writer's review label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue repositories Content related to repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pull requests from jsoref/github-docs
3 participants
@jsoref @lucascosti @cmwilson21