Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added filter out documentation using - #1248

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Added filter out documentation using - #1248

merged 3 commits into from
Dec 2, 2020

Conversation

Julian88Tex
Copy link
Contributor

@Julian88Tex Julian88Tex commented Nov 10, 2020 •
edited
Loading

Why:

What's being changed:

  • Add one line mentioning search term filter out modifier -

Contribution

  • Idea for this method of filtering was provided by @davisagli

@welcome
Copy link

welcome bot commented Nov 10, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@Julian88Tex Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 13, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 21, 2020
@janiceilene
Copy link
Contributor

This is not stale! Thanks for your patience @Julian88Tex as our small team works through all of the amazing contributions 🌟

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 23, 2020
@Julian88Tex
Copy link
Contributor Author

@janiceilene thanks for keeping it alive!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 1, 2020
@shati-patel shati-patel removed the stale There is no recent activity on this issue or pull request label Dec 2, 2020
lecoursen
lecoursen approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Julian88Tex! I'll merge this now.

@lecoursen lecoursen merged commit b16c30a into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@janiceilene janiceilene mentioned this pull request Dec 4, 2020
Closed
@Julian88Tex Julian88Tex deleted the patch-1 branch December 4, 2020 20:23
This was referenced Jun 23, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2021
Open
Octomerger pushed a commit that referenced this pull request Dec 1, 2021
@peterbe
Make the staging files, for deployments, as lean as possible (#23049)
1c4d326 
* Experiment with making the tarball smaller

Part of #1248

* try this

* stop debugging

* delete translations too

* delete heavy search indexes too

* push and popd

* try this hack

* delete but leave directory

* debug more

* faster delete of translations

* less loud

* async await

* async await

* no tree

* simplify

* experimenting more

* unfinished

* only the large files

* change order

* brotli with level 6

* cope better with decorated rest json files

* tidying

* keep images

* cleaning

* cleaning up

* refactored function

* try this

* better comment

* remove console logging

* more important changes

* improved fs.accessSync check
Octomerger pushed a commit that referenced this pull request Dec 7, 2021
@peterbe
make lib/rest/index.js callable (#23214)
9a7a8a7 
* Experiment with making the tarball smaller

Part of #1248

* try this

* stop debugging

* delete translations too

* delete heavy search indexes too

* push and popd

* try this hack

* delete but leave directory

* debug more

* faster delete of translations

* less loud

* async await

* async await

* no tree

* simplify

* experimenting more

* unfinished

* only the large files

* change order

* brotli with level 6

* cope better with decorated rest json files

* tidying

* keep images

* cleaning

* cleaning up

* refactored function

* try this

* better comment

* remove console logging

* more important changes

* make lib/rest/index.js callable

Part of #1177

* memoize

* remove console logging
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Mar 22, 2024
Open
@RanaAhmed2020 RanaAhmed2020 mentioned this pull request Mar 22, 2024
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Mar 22, 2024
Open
@aliscco aliscco mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julian88Tex @janiceilene @lecoursen @shati-patel