chore: Format json files with Prettier

[nschonni]

Why:

EditorConfig was added in a previous PR. This does a one time cleanup so the next changes to the files are a simpiler diff that won't have to include any of the whitespace cleanups

What's being changed:

Probably easiest to view in the "whitespace ignored view" https://github.com/github/docs/pull/1177/files?diff=unified&w=1
Ran https://github.com/caarlos0/jsonfmt as a quick why to consistently apply the whitespace as a on-off instead of trying to introduce something with a lot of opinons like Prettier:

• Match indenting in EditorConfig of 2 spaces
• Add missing EOF
• Collapse empty arrays and objects

Check off the following:

• All of the tests are passing.
• I have reviewed my changes in staging.
• For content changes, I have reviewed the localization checklist
• For content changes, I have reviewed the Content style guide for GitHub Docs.

[heiskr]

Makes sense to me. 🙏🏼 Thanks!

[chiedo]

I connected with @sarahs and most of these files are generated automatically by scripts... it wouldn't hurt anything to merge this, but the files will just get overwritten with the old whitespace at some point.

So I'm not clear what the benefit to merging this would be.

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[nschonni]

@chiedo now that the Prettier for Yaml PR landed, would it make sense to add that for the JSON files too or just ignore a particular pattern of generated files?

[chiedo]

just ignore a particular pattern of generated files

My opinion is this!

[nschonni]

@chiedo if you provide a pattern I can add it to the .prettierignore. Flip side is that now that this is automated and linted, it's easier to re-apply to the generated files as they land, even if they tool produces something slightly different natively

[chiedo]

Thanks @nschonni! I'll follow back up in a few weeks. We're going to start reviewing all open source PRs on Mondays (starting after Thanksgiving) as a team. We've had a few workflow changes break internal processes over the past week so we're going to start looping everyone in to get sign off.

[nschonni]

@rachmari I took your approach for the Yaml files in update-files.js and added the json extension 😄

[chiedo]

@nschonni sorry on the delay here! Most of these JSON files are generated via automation so we don’t see a pressing reason to merge this PR as they’ll get overwritten. So we’re going to close this PR for the time being. Moving forward can you start by opening an issue rather than a PR so we can make sure we can commit to the issue before you start working on it?

[nschonni]

@chiedo this hooks into the script like the Yaml files for the generated content