Remove pull request template #18104
+31
−18
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ### Pull Request reminders for autofix | ||
|
|
||
| (internal access required) | ||
|
|
||
| - [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to `.ql`, `.qll`, or `.qhelp` files. See [the documentation](https://github.com/github/codeql-team/blob/main/docs/best-practices/validating-autofix-for-query-changes.md). | ||
| - [ ] Changes to autofix are validated [at scale](https://github.com/github/codeql-dca/blob/main/doc/autofix.md). | ||
| - [ ] Adding a new query? Consider also [adding the query to autofix](https://github.com/github/codeml-autofix/blob/main/docs/updating-query-support.md#adding-a-new-query-to-the-query-suite). | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||
| name: Check change note and reminders | ||||
|
|
||||
| permissions: | ||||
| pull-requests: read | ||||
|
|
@@ -9,17 +9,39 @@ on: | |||
| paths: | ||||
| - "*/ql/src/**/*.ql" | ||||
| - "*/ql/src/**/*.qll" | ||||
| - "*/ql/src/**/*.qhelp" | ||||
| - "*/ql/lib/**/*.ql" | ||||
| - "*/ql/lib/**/*.qll" | ||||
| - "*/ql/lib/**/*.qhelp" | ||||
| - "*/ql/lib/**/*.yml" | ||||
| - "shared/**/*.ql" | ||||
| - "shared/**/*.qll" | ||||
| - "shared/**/*.qhelp" | ||||
| - "!**/experimental/**" | ||||
| - "!ql/**" | ||||
| - "!rust/**" | ||||
| - ".github/workflows/check-change-note.yml" | ||||
|
|
||||
| jobs: | ||||
| add-pr-reminders: | ||||
| env: | ||||
| REPO: ${{ github.repository }} | ||||
| PULL_REQUEST_NUMBER: ${{ github.event.number }} | ||||
|
There was a problem hiding this comment.
Suggested change
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
So we can skip declaring our own variable here. There was a problem hiding this comment. I was just following along with Is there a reason to change it in this job, but not the other? There was a problem hiding this comment. I have pushed a commit that makes use of GITHUB_REPOSITORY everywhere in this file. |
||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||
| runs-on: ubuntu-latest | ||||
| steps: | ||||
|
|
||||
| - name: Check if the 'reminders' comment exists | ||||
| run: | | ||||
| reminder_comment=$(gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" --jq '.[] | select(.body | test("### Pull Request reminders for autofix"))') | ||||
|
|
||||
esbena marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
| if [ -z "$reminder_comment" ]; then | ||||
| echo "The reminder comment does not exist. Adding it." | ||||
| comment_body="$(cat .github/pr-comment-reminder.md)" | ||||
|
|
||||
| gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" -f body="$comment_body" | ||||
| fi | ||||
esbena marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
|
|
||||
| check-change-note: | ||||
| env: | ||||
| REPO: ${{ github.repository }} | ||||
|
|
||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please restrict this comment to only occur when there are changes in
*/ql/src/**? Otherwise I think we'll add too much noise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking back: didn't we actually decide against this commenting approach in the first place in #17017 (comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, upon further thought, I don't think we should spam PRs with a comment like this.