Remove pull request template #18104
Remove pull request template #18104
Conversation
Replace with an updated check-change-note.yml workflow. Add a comment whenever a pull request has changes that may need to be tested in autofix. Also, remove parts of the checklist that are not related to autofix.
|
The new workflow job won't run until this PR is merged since it runs under |
| - "!**/experimental/**" | ||
| - "!ql/**" | ||
| - "!rust/**" | ||
| - ".github/workflows/check-change-note.yml" | ||
|
|
||
| jobs: | ||
| add-pr-reminders: | ||
| env: | ||
| REPO: ${{ github.repository }} |
There was a problem hiding this comment.
| REPO: ${{ github.repository }} |
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
explains GITHUB_REPOSITORY as
The owner and repository name. For example, octocat/Hello-World.
So we can skip declaring our own variable here.
There was a problem hiding this comment.
I was just following along with REPO elsewhere in the file. Looking in history, I see that REPO was added 13 months ago...by you. 😄
Is there a reason to change it in this job, but not the other?
There was a problem hiding this comment.
I have pushed a commit that makes use of GITHUB_REPOSITORY everywhere in this file.
| @@ -0,0 +1,7 @@ | |||
| ### Pull Request reminders for autofix | |||
There was a problem hiding this comment.
Can we please restrict this comment to only occur when there are changes in */ql/src/**? Otherwise I think we'll add too much noise.
There was a problem hiding this comment.
Thinking back: didn't we actually decide against this commenting approach in the first place in #17017 (comment)?
There was a problem hiding this comment.
Yeah, upon further thought, I don't think we should spam PRs with a comment like this.
|
I just had a chat with @oscarsj about this. In the next few weeks, his team will be looking into how to make the autofix testing tools easier to use. I'll keep this PR open for now and we can discuss later. Thanks for your feedback so far. |
Replace with an updated check-change-note.yml workflow.
Add a comment whenever a pull request has changes that may need to be tested in autofix. Also, remove parts of the checklist that are not related to autofix.