Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix jump steps generated by IIFEs and exception flow #18043

Draft
wants to merge 19 commits into
base: js/shared-dataflow-branch
Choose a base branch
from
Draft

JS: Fix jump steps generated by IIFEs and exception flow #18043

wants to merge 19 commits into from
+387 −84

Commits on Nov 18, 2024

  1. JS: Add exception test case

    @asgerf
    asgerf committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5ed362f View commit details
    Browse the repository at this point in the history

  2. JS: Port exception steps to a universal summary

    @asgerf
    asgerf committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7acc568 View commit details
    Browse the repository at this point in the history

  3. JS: Add test case for false flow through IIFEs 

    We generate local flow steps into and out of IIFEs, but these come jump steps automatically, resulting in FPs.
    @asgerf
    asgerf committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7f2eae0 View commit details
    Browse the repository at this point in the history

  4. JS: Remove jump steps from IIFE steps

    @asgerf
    asgerf committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    37676f4 View commit details
    Browse the repository at this point in the history

  5. JS: Disable variable capture heuristic 

    Bailing out can be more expensive as the resulting jump steps themselves
cause perf issues. The limit of 100 variables per scope has also been
added in the interim, which handles the cases that this needed to cover.
    @asgerf
    asgerf committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    023dcce View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. JS: Add tests explaining why the IIFE in f2 didn't work

    @asgerf
    asgerf committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d2daec4 View commit details
    Browse the repository at this point in the history

  2. JS: Use getUnderlyingValue() a few places in VariableCapture

    @asgerf
    asgerf committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    80a5a59 View commit details
    Browse the repository at this point in the history

  3. JS: Block InsecureRandomness flow into test files

    @asgerf
    asgerf committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0166990 View commit details
    Browse the repository at this point in the history

  4. JS: More aggressive test file classification

    @asgerf
    asgerf committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d1c9e47 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. JS: Add test case

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b7dd455 View commit details
    Browse the repository at this point in the history

  2. JS: Fix callback check so it works without parameters

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dcdb2e5 View commit details
    Browse the repository at this point in the history

  3. JS: Propagate exceptions from summarized callables by default

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    948d21c View commit details
    Browse the repository at this point in the history

  4. Add test for exception flow out of finally()

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    84820ad View commit details
    Browse the repository at this point in the history

  5. JS: Only apply exception propagator when no other summary applies 

    Previously a few Promise-related methods were special-cased, which is no longer needed.
    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4e62a51 View commit details
    Browse the repository at this point in the history

  6. JS: More docs

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ce00bd2 View commit details
    Browse the repository at this point in the history

  7. JS: Update DataFlowConsistency

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9dad2d6 View commit details
    Browse the repository at this point in the history

  8. JS: Update missed flow in capture-flow.js 

    We previously caught this flow because of a heuristic in capture flow. We'll have to fix it properly later.
    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1ac7591 View commit details
    Browse the repository at this point in the history

  9. JS: Update lost result in insecure-download 

    The VariableCapture library consumes one component of the access path limit, which means we lose this result
    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7a77432 View commit details
    Browse the repository at this point in the history

  10. JS: Update output changes to nodes/edges/subpaths

    @asgerf
    asgerf committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    930a7b6 View commit details
    Browse the repository at this point in the history