JS: Fix jump steps generated by IIFEs and exception flow #18043
+308
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues that cause performance (and precision) problems:
js/insecure-randomness
now blocks flow through test cases. Perhaps more queries ought to do this, but it seems particularly problematic for this query. Also broadens our classifications of test files a bit.Evaluation of d1c9e47 looks good:
vscode
, which means it is down to being "only" 79% slower than onmain
(the similar numbers is a coincidence).js/insecure-randomness
Evaluation of d1c9e47 against main shows that we're down to a median 26% slowdown, with a 100% worst-case slowdown.
Evaluation of ce00bd2 vs d1c9e47 is underway