C#: Add support for flow through side-effects on static fields - #16576
Merged
Conversation
aschackmull
previously approved these changes
May 23, 2024
aschackmull
left a comment
aschackmull
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but be sure to check dca before merging.
hvitved
force-pushed
the
csharp/static-field-side-effect
branch
from
May 27, 2024 12:18
6e49777 to
34923bf
Compare
hvitved
force-pushed
the
csharp/static-field-side-effect
branch
from
August 12, 2024 08:02
34923bf to
1bcac50
Compare
hvitved
marked this pull request as ready for review
August 13, 2024 10:10
aschackmull
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #16500 for Java.