Java: Add support for flow through side-effects on static fields. - #16500
Merged
aschackmull merged 2 commits intoMay 24, 2024
Conversation
Contributor
Author
|
There are a bunch of additional results. The steps provided by this PR look reasonable, but it appears that I'm running into trouble with a bunch of the generated |
Contributor
|
|
Contributor
Author
aschackmull
force-pushed
the
java/static-field-side-effect
branch
from
May 23, 2024 11:03
a40d929 to
1bc3f6b
Compare
Contributor
Author
|
I've rebased this PR, as the 3 spinoff PRs are now merged, so this PR is back to being nice and simple. |
atorralba
approved these changes
May 23, 2024
atorralba
left a comment
atorralba
left a comment
Contributor
There was a problem hiding this comment.
I think I'm approving exactly the same set of changes as the last time 😄.
hvitved
approved these changes
May 23, 2024
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
May 29, 2024
This was based on the equivalent for java: github#16500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15972