Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix apt-get command in bump.yml, restore workflow summaries #101

Merged
merged 3 commits into from
Dec 3, 2024

Commits on Dec 2, 2024

  1. ci: Fix apt-get command in bump.yml

    The bump.yml workflow, running on a schedule, has always failed to
    complete so far [0]. This is because an "apt-get" command is missing the
    "install" subcommand, resulting in apt trying to interpret the name of
    the package we want to install as a subcommand, making the workflow
    fail.
    
    Fix the command, to hopefully make the workflow succeed.
    
    [0] https://github.com/githedgehog/dataplane/actions/workflows/bump.yml
    
    Fixes: 08ac167 ("build: Rework many parts of the build framework")
    Signed-off-by: Quentin Monnet <[email protected]>
    qmonnet committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8303063 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Revert "ci: Remove summary steps"

    This reverts commit 6d69a4e.
    
    I thought we could have the individual jobs marked as required. But we
    hit the following issue:
    
    Individual jobs (build, test, push in dev.yml and sterile.yml) use a
    matrix to run with multiple Rust toolchains (stable/nightly). The Rust
    toolchain appears in the job name, whether we specify it or not. Then
    when trying to fill the list of required checks in GitHub's interface,
    we've got to use these names and as far as I can tell this must be an
    exact match, so we need to specify the toolchain. So far this looks good
    because ideally we'd like to have the checks using the stable toolchain,
    not nightly, as required. However, when the job is skipped, because no
    relevant files are touched in the Pull Request, the matrix is not
    generated, and the toolchain name is not appended to the job name as one
    might expect. In such a case, it's no longer possible to match the
    required checks with the titles of the status checks for the Pull
    Request, and the Pull Request is blocked. Let's re-add the summaries so
    we can mark them as required.
    
    Signed-off-by: Quentin Monnet <[email protected]>
    qmonnet committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    3bb7467 View commit details
    Browse the repository at this point in the history
  2. ci: Remove manual insertion of matrix value from job titles

    GitHub adds the values from the matrix to the job titles by default if
    they're similar between concurrent jobs, there is no need to specify
    them manually.
    
    Signed-off-by: Quentin Monnet <[email protected]>
    qmonnet committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    db3ab74 View commit details
    Browse the repository at this point in the history