ci: Fix apt-get command in bump.yml, restore workflow summaries #101
Conversation
The bump.yml workflow, running on a schedule, has always failed to complete so far [0]. This is because an "apt-get" command is missing the "install" subcommand, resulting in apt trying to interpret the name of the package we want to install as a subcommand, making the workflow fail. Fix the command, to hopefully make the workflow succeed. [0] https://github.com/githedgehog/dataplane/actions/workflows/bump.yml Fixes: 08ac167 ("build: Rework many parts of the build framework") Signed-off-by: Quentin Monnet <[email protected]>
|
Oh no, it looks like skipping jobs entirely prevents GitHub from creating the various status check entries with the Rust toolchain versions ( |
qmonnet
force-pushed
the
pr/qmonnet/bump-fix
branch
from
a873114
to
8303063
Compare
|
We can bypass the rule here, but I'll need to find a way to address this. Not sure what's the cleanest solution 😕 |
qmonnet
force-pushed
the
pr/qmonnet/bump-fix
branch
from
cc428af
to
3a29a6d
Compare
This reverts commit 6d69a4e. I thought we could have the individual jobs marked as required. But we hit the following issue: Individual jobs (build, test, push in dev.yml and sterile.yml) use a matrix to run with multiple Rust toolchains (stable/nightly). The Rust toolchain appears in the job name, whether we specify it or not. Then when trying to fill the list of required checks in GitHub's interface, we've got to use these names and as far as I can tell this must be an exact match, so we need to specify the toolchain. So far this looks good because ideally we'd like to have the checks using the stable toolchain, not nightly, as required. However, when the job is skipped, because no relevant files are touched in the Pull Request, the matrix is not generated, and the toolchain name is not appended to the job name as one might expect. In such a case, it's no longer possible to match the required checks with the titles of the status checks for the Pull Request, and the Pull Request is blocked. Let's re-add the summaries so we can mark them as required. Signed-off-by: Quentin Monnet <[email protected]>
GitHub adds the values from the matrix to the job titles by default if they're similar between concurrent jobs, there is no need to specify them manually. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/bump-fix
branch
from
3a29a6d
to
db3ab74
Compare
|
I couldn't find a simple way to mark the jobs with the So instead, I re-added the job summaries that we had before, so we can mark these as required. We don't get the distinction between the toolchains, but we could expand the summary to retrieve some output specific to each job if we really want to. That doesn't look super clean, but should work. |
qmonnet
changed the title
The bump.yml workflow, running on a schedule, has always failed to complete so far. This is because an "apt-get" command is missing the "install" subcommand, resulting in apt trying to interpret the name of the package we want to install as a subcommand, making the workflow fail.
Fix the command, to hopefully make the workflow succeed.