install-from-source: update libssl for alpine #1574
Conversation
ldennington
force-pushed
the
update-libssl
branch
from
b3b267f
to
4407b77
Compare
Not quite sure if I picked up what you're putting down, but I added a check to make sure the user is running on 3.15 or greater. Will that suffice? |
ldennington
force-pushed
the
update-libssl
branch
from
4407b77
to
000427f
Compare
Update the install from source script on Linux to install the .NET 8 SDK. Verified this fix in manual run of https://github.com/git-ecosystem/git-credential-manager/actions/runs/8697380253 Note the Alpine issue is to be fixed in a separate PR: #1574
There was a problem hiding this comment.
I'd like to propose this PR address this issue instead:
#1582
It copes with both 3.14 and 3.15+ Alpine requirements.
The `validate-install-from-source` workflow is currently failing [1]. According to [2] and [3], the solution is to upgrade the libssl version from 1.1 to 3, as version 1.1 is out of support. Since this version is only supported on Alpine 3.15 and later, we detect the version of Alpine the user is running on and set this dependency version accordingly. 1: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8604126129 2: https://stackoverflow.com/questions/77640298/dockerfile-unable-to-select-packages-linux-alpine 3: https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine
ldennington
force-pushed
the
update-libssl
branch
from
000427f
to
e5981ea
Compare
Actually, thinking about this a little more, it seemed like the best idea would be to set the version of |
Sorry! I didn't see this before submitting my updates. I'll take a look at your PR. |
|
Closed in favor of #1582 |
The version of libssl available in the Alpine package feeds changed with version 3.15. The latest libssl package is 1.1 in 3.14.x and earlier, but newer versions only have libssl3. Add a check for the Alpine version in the install from source script and switch between installing libssl3 and libssl1.1 depending on the distro version. Also add another entry to the test matrix of distributions to include a 3.14.x Alpine version. This replaces the two other PRs that aimed to address this issue: - #1535 - #1574 Tested the updated workflow here: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8698286553/job/23855027830
The
validate-install-from-sourceworkflow is currently failing [1]. Accordingto [2] and [3], the solution is to upgrade the libssl version from 1.1 to 3, as
version 1.1 is out of support. Since this version is only supported on Alpine
3.15 and later, we detect the version of Alpine the user is running on and set
this dependency version accordingly.
1: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8604126129
2: https://stackoverflow.com/questions/77640298/dockerfile-unable-to-select-packages-linux-alpine
3: https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine