Alpine Linux: avoid requiring unsupported OpenSSL version #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL v1.1.* is no longer provided by Alpine Linux v3.19 according to https://pkgs.alpinelinux.org/packages?name=libssl1.1&branch=v3.19&repo=&arch=&maintainer= However, OpenSSL v3.* is, so let's use that instead. Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
requested changes
Feb 12, 2024
| @@ -189,7 +189,7 @@ case "$distribution" in | |||
| $sudo_cmd apk update | |||
|
|
|||
| # Install dotnet/GCM dependencies. | |||
| install_packages apk add "curl git icu-libs krb5-libs libgcc libintl libssl1.1 libstdc++ zlib which bash coreutils gcompat" | |||
| install_packages apk add "curl git icu-libs krb5-libs libgcc libintl libssl3 libstdc++ zlib which bash coreutils gcompat" | |||
There was a problem hiding this comment.
According to the .NET docs, the dependency for OpenSSL should still be 1.1 on 3.14.x and older Alpine.. we may need to switch on the Alpine version in this script.
https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine#dependencies
This was referenced Apr 15, 2024
mjcheetham
requested changes
Apr 16, 2024
There was a problem hiding this comment.
I'd like to propose this PR address this issue instead:
#1582
It copes with both 3.14 and 3.15+ Alpine requirements.
mjcheetham
added a commit
that referenced
this pull request
Apr 16, 2024
The version of libssl available in the Alpine package feeds changed with version 3.15. The latest libssl package is 1.1 in 3.14.x and earlier, but newer versions only have libssl3. Add a check for the Alpine version in the install from source script and switch between installing libssl3 and libssl1.1 depending on the distro version. Also add another entry to the test matrix of distributions to include a 3.14.x Alpine version. This replaces the two other PRs that aimed to address this issue: - #1535 - #1574 Tested the updated workflow here: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8698286553/job/23855027830
|
Addressed in #1582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL v1.1.* is no longer provided by Alpine Linux v3.19 according to https://pkgs.alpinelinux.org/packages?name=libssl1.1&branch=v3.19&repo=&arch=&maintainer=
However, OpenSSL v3.* is, so let's use that instead.
[EDIT] This fixes the currently-broken
validate-install-from-sourcebuild (see here for a successful build of that workflow at the tip of this PR's branch).