Fix broken AssertJ specifications #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A substantial number of AssertJ usages lack assertion operators and therefore are ineffectual. Rewrite these assetions into functional AssertJ-native variants. Doing so induces a score of failures from misspecified tests so mark those fallible pending correction.
Correct and restore all the tests marked fallible by commit e7cf70a (Fix AssertJ API usage, 2024-02-23). Errors predominantly revolve around expecting the presence of the property "commit.id.full" instead of the mutually exclusive default of "commit.id", so for those tests we just flip the expectation without further consideration. In at least one case we clearly expect the presence of "commit.id.full" so for that test we retain the expectation and instead override the commit ID generation mode.
A few AssertJ assertions can be expressed with more AssertJ-native assertion operators; do so.
|
Oh, this is #102. Never mind. |
|
Thanks for your contribution! Indeed that was recently improved in the MR you linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of specifications expressed with AssertJ invoke the API incorrectly, leaving the assertions ineffectual. Fixing these reveals that several test cases express minor expectations that are not met by the implementation and require review for correctness -- there is strong evidence that the expectations, not the implementation, are in error, namely by way of
commit.idbeing default and mutually exclusive withcommit.id.full. Additionally, some expectations can trivially be expressed with more AssertJ-native assertion operators.This PR restores function to the nonfunctional expectations, attempts to correct the resulting broken tests, and superficially rewrites AssertJ-expectations into more native variants.