Improve tests #102
Merged
Improve tests #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--release` also verifies that only API from that Java version is used. Otherwise when building with a JDK newer than the target version it would be possible to accidentally use API not available in the target version.
The properties files are written with OS-specific line breaks, but the expected output previously only considered '\n' instead of Windows '\r\n'. Also simplified the code reading the properties file content in PropertiesFileGeneratorTest.
This AssertJ method requires that afterwards you write the actual assertion, e.g. `assertThat(value).isFalse()` `assertThat(value)` on its own does not do anything and always passes.
… id mode `CommitIdGenerationMode.FLAT` is the default but some of the tests seem to erroneously expect the full format by default. This was previously not detected because that test class was using `assertThat` incorrectly.
|
Thanks for your contributions! I never ran the tests on windows so thanks for fixing that :-) Changes look good for me, so thanks again I'm going ahead and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tries to improve the unit tests; in particular:
PropertiesFileGeneratorTestfailing on WindowsGitCommitIdPluginIntegrationTestnot usingassertThat(...)correctly & simplify assertionsSee the commit messages for details. Feedback is appreciated!
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B