Skip to content

#1215: Migrate to slnx solution file format#1292

Merged
badcel merged 1 commit intogircore:mainfrom
kashif-forks:feature/#1215-migrate-to-slnx
Nov 30, 2025
Merged

#1215: Migrate to slnx solution file format#1292
badcel merged 1 commit intogircore:mainfrom
kashif-forks:feature/#1215-migrate-to-slnx

Conversation

@kashifsoofi
Copy link
Copy Markdown
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@kashifsoofi kashifsoofi force-pushed the feature/#1215-migrate-to-slnx branch from 1eb6d3f to b8c384f Compare August 6, 2025 15:59
@badcel
Copy link
Copy Markdown
Member

badcel commented Aug 6, 2025

Is slnx already supported oficially by dotnet?

@kashifsoofi
Copy link
Copy Markdown
Contributor Author

Is slnx already supported oficially by dotnet?

Yes it seems to be the case, since sdk version 9.0.200, build is successful as well

@badcel
Copy link
Copy Markdown
Member

badcel commented Aug 7, 2025

Hm it seem to work for dotnet 8, too.

I will need to test this with Rider and read a little bit in the Microsoft docs before merging.

@badcel badcel linked an issue Aug 7, 2025 that may be closed by this pull request
@badcel
Copy link
Copy Markdown
Member

badcel commented Aug 7, 2025

It reads like it is not generally available. So I would wait a little more before merging this.

@UrtsiSantsi
Copy link
Copy Markdown
Contributor

I was planning to to this a few moths ago, but it is not in Fedora yet (even now), so the ci will not work

@badcel
Copy link
Copy Markdown
Member

badcel commented Nov 21, 2025

I think we can give this a go. I can't find the docs stating that it's not fully released. Can you rebase on current main as the code is on a pretty old base.

@kashifsoofi kashifsoofi force-pushed the feature/#1215-migrate-to-slnx branch from b8c384f to 674cd40 Compare November 21, 2025 15:58
@kashifsoofi
Copy link
Copy Markdown
Contributor Author

Updated

@badcel
Copy link
Copy Markdown
Member

badcel commented Nov 22, 2025

Hm something is off: Buildalyzer seems to not support slnx: Buildalyzer/Buildalyzer#295

But the CI is green here. On my local main branch the tests are red. Currently I'm not sure if the unit tests are running correctly at all.

@badcel
Copy link
Copy Markdown
Member

badcel commented Nov 29, 2025

As the buildalyzer dependency got removed in #1362 and all the nugets are updated and there is dotnet 10 support I think this should work if you just rebase it on current 'main'.

@kashifsoofi kashifsoofi force-pushed the feature/#1215-migrate-to-slnx branch from 674cd40 to d153ed1 Compare November 30, 2025 11:45
@kashifsoofi
Copy link
Copy Markdown
Contributor Author

As the buildalyzer dependency got removed in #1362 and all the nugets are updated and there is dotnet 10 support I think this should work if you just rebase it on current 'main'.

Rebased

@badcel
Copy link
Copy Markdown
Member

badcel commented Nov 30, 2025

Just checked it one more time in Rider and it works like expected :-).

Thanks again for your contribution and ongoing support 🚀

@badcel badcel merged commit 350f20b into gircore:main Nov 30, 2025
4 checks passed
@kashifsoofi kashifsoofi deleted the feature/#1215-migrate-to-slnx branch November 30, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to slnx solution file format

3 participants