Skip to content

Introduction of solution info and project file info#295

Merged
Corniel merged 5 commits intoBuildalyzer:mainfrom
Corniel:solution-info
Mar 9, 2026
Merged

Introduction of solution info and project file info#295
Corniel merged 5 commits intoBuildalyzer:mainfrom
Corniel:solution-info

Conversation

@Corniel
Copy link
Copy Markdown
Collaborator

@Corniel Corniel commented Nov 17, 2024

Both SolutionInfo and ProjectInfo are immutable objects, describing the solution and its projects under analysis. They reflect the information resolved by calling MS's SolutionFile, and our own ProjectFile. As a result two properties of IAnalyzerManager are marked as obsolete.

This should also close #303

Before this can be finished, first #316 should be completed.

As this build now fails due to the issue reported at #328, also build dependency updates are included.

@Frulfump
Copy link
Copy Markdown
Contributor

Since dotnet/sdk#50022 is now fixed and a part of .NET 10 this is even more relevant hoping you get the review you were looking for in #304 (comment)

@baronfel
Copy link
Copy Markdown

I'm confused - this PR doesn't add SLNX support at all? Or are you intending to introduce this as an 'abstraction' and then convert SolutionInfo over into being based on the Microsoft.VisualStudio.SolutionPersistence models?

@Corniel
Copy link
Copy Markdown
Collaborator Author

Corniel commented Aug 24, 2025

@baronfel Originally, this PR had nothing to do with SLNX support. But I'll update this PR so that the SolutionInfo is an immutable abstraction that both can deal with .sln and .slnx files.

@Corniel
Copy link
Copy Markdown
Collaborator Author

Corniel commented Aug 25, 2025

@Frulfump and @baronfel I've updated the implementation, now to support SLNX. It is not perfect (yet) but it is worth a try I guess.

@kudima03
Copy link
Copy Markdown

Hi @josephwoodward @phmonte,
many dependent projects are now in need of slnx support, especially with the release of .NET 10.
Could you please review the PR when you have a moment?

@Corniel
Copy link
Copy Markdown
Collaborator Author

Corniel commented Nov 16, 2025

@kudima03 I would urge you to also give some feedback/review. The more people who check a PR, the better.

Comment thread src/Buildalyzer/Buildalyzer.csproj Outdated
Copy link
Copy Markdown

@AlbertoMonteiro AlbertoMonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Frulfump <Frulfump@users.noreply.github.com>
@Corniel Corniel merged commit cc90976 into Buildalyzer:main Mar 9, 2026
0 of 3 checks passed
@Corniel Corniel deleted the solution-info branch March 9, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML Solution File (*.SLNX)” format support

5 participants