Bump the dotnet group with 17 updates - #68
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps AwesomeAssertions from 9.5.0 to 9.6.0 Bumps CliWrap from 3.10.4 to 3.10.5 Bumps editorconfig from 0.17.0 to 0.18.0 Bumps Microsoft.Data.SqlClient from 7.0.2 to 7.0.3 Bumps Microsoft.Extensions.AI.Abstractions from 10.9.0 to 10.10.0 Bumps Microsoft.Extensions.Configuration.Abstractions from 10.0.11 to 10.0.12 Bumps Microsoft.Extensions.DependencyInjection.Abstractions from 10.0.11 to 10.0.12 Bumps Microsoft.Extensions.FileSystemGlobbing from 10.0.11 to 10.0.12 Bumps Microsoft.Extensions.Logging.Abstractions from 10.0.11 to 10.0.12 Bumps Microsoft.Extensions.Options from 10.0.11 to 10.0.12 Bumps Nerdbank.GitVersioning from 3.10.91 to 3.10.94 Bumps Oracle.ManagedDataAccess.Core from 23.26.300 to 23.26.301 Bumps Soenneker.Extensions.Enumerable from 4.0.649 to 4.0.667 Bumps Soenneker.Extensions.Enumerable.String from 4.0.1410 to 4.0.1461 Bumps Soenneker.Extensions.String from 4.0.723 to 4.0.762 Bumps SonarAnalyzer.CSharp from 10.32.0.713 to 10.34.0.3385 Bumps TUnit from 1.65.63 to 1.68.4 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dotnet - dependency-name: CliWrap dependency-version: 3.10.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: editorconfig dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dotnet - dependency-name: Microsoft.Data.SqlClient dependency-version: 7.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Microsoft.Extensions.AI.Abstractions dependency-version: 10.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dotnet - dependency-name: Microsoft.Extensions.Configuration.Abstractions dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Microsoft.Extensions.DependencyInjection.Abstractions dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Microsoft.Extensions.FileSystemGlobbing dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Microsoft.Extensions.Options dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Nerdbank.GitVersioning dependency-version: 3.10.94 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Oracle.ManagedDataAccess.Core dependency-version: 23.26.301 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Soenneker.Extensions.Enumerable dependency-version: 4.0.667 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Soenneker.Extensions.Enumerable.String dependency-version: 4.0.1461 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: Soenneker.Extensions.String dependency-version: 4.0.762 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dotnet - dependency-name: SonarAnalyzer.CSharp dependency-version: 10.34.0.3385 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dotnet - dependency-name: TUnit dependency-version: 1.68.4 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dotnet ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated AwesomeAssertions from 9.5.0 to 9.6.0.
Release notes
Sourced from AwesomeAssertions's releases.
9.6.0
What's Changed
New features
Fixes
Documentation
Others
Dependencies
New Contributors
... (truncated)
Commits viewable in compare view.
Updated CliWrap from 3.10.4 to 3.10.5.
Release notes
Sourced from CliWrap's releases.
3.10.5
What's Changed
Enhancements
SimplexStreamby making it Memory-first by @Tyrrrz in OptimizeSimplexStreamby making it Memory-first Tyrrrz/CliWrap#343Bugs
Full Changelog: Tyrrrz/CliWrap@3.10.4...3.10.5
Commits viewable in compare view.
Updated editorconfig from 0.17.0 to 0.18.0.
Release notes
Sourced from editorconfig's releases.
0.18.0
editorconfig/editorconfig-core-net@0.17.0...0.18.0
View the full list of issues and PRs
Commits viewable in compare view.
Updated Microsoft.Data.SqlClient from 7.0.2 to 7.0.3.
Release notes
Sourced from Microsoft.Data.SqlClient's releases.
7.0.3
This update brings the following changes since the 7.0.2 release:
The core driver and its companion packages ship together as version
7.0.3. Update the companion packages you use alongside the driver to7.0.3. Assembly versions remain7.0.0.0, unchanged from7.0.2.Companion package release notes
Changed
Microsoft.Data.SqlClient.SNIandMicrosoft.Data.SqlClient.SNI.runtimedependencies to 6.0.3 (was 6.0.2).(#4599)
Fixed
Fixed a
SqlBulkCopyregression in environments where the application login cannot readsys.all_columns. Bulk copy now falls back to the earlier column-discovery behavior when that permission is unavailable. Support for hidden columns and SQL Graph column aliases still requires access to the metadata view.(#4370, #4306, #4402)
Fixed a memory-allocation regression in connection and command operations caused by formatting diagnostic strings even when tracing was disabled. Also corrected trace messages that reported an incorrect object ID or could throw
FormatExceptionwhen traced values contained braces.(#4528, #4533)
Fixed
ServerCertificatevalidation on the managed SNI path so the configured certificate is compared against the server certificate even when the server certificate passes chain and host-name validation. When certificate validation is enabled, a missing, unreadable, or invalid certificate file, a certificate mismatch, or a missing server certificate now causes the TLS handshake to fail instead of bypassing the configured certificate check. (net8.0/net9.0 only)(#4445, #4583)
Fixed Always Encrypted VSM/HGS enclave attestation to verify that the enclave public key used to establish a session matches the key committed to by the signed attestation report. Missing, malformed, or mismatched key-binding data now causes attestation to fail before the session secret is derived.
(#4532, #4553)
Fixed
SqlConnection.AccessTokenCallbacknot disabling Transparent Network IP Resolution by default, making it consistent withSqlConnection.AccessToken. An explicitly configuredTransparentNetworkIPResolutionconnection-string value still takes precedence. (net462 only)(#4520, #4561)
Fixed authentication state handling so clearing
SqlConnection.AccessToken,AccessTokenCallback, orSspiContextProviderpreserves the other authentication values in the connection pool key. Cloning a connection or updating its credential also preserves itsSspiContextProvider. Combining a non-nullSspiContextProviderwithAccessTokenorAccessTokenCallbacknow throwsInvalidOperationExceptioninstead of silently discarding authentication state; applications must use one authentication mechanism at a time.(#4520, #4561, #4644)
Fixed configurable retry logic installing a permanent, process-wide assembly-resolution handler that could interfere with unrelated assembly loading. The handler is now active only while an explicitly configured custom retry provider is resolved and constructed, and probes
AppContext.BaseDirectoryinstead of the current working directory. Place custom retry assemblies in the application base directory; dependencies loaded after provider construction must be resolvable through normal application dependency resolution or an application-provided handler. (net8.0/net9.0 only)(#2214, #4547, #4663)
Contributors
We thank the following public contributors. Their efforts toward this project are very much appreciated.
Target Platform Support
... (truncated)
Commits viewable in compare view.
Updated Microsoft.Extensions.AI.Abstractions from 10.9.0 to 10.10.0.
Release notes
Sourced from Microsoft.Extensions.AI.Abstractions's releases.
10.10.0
This month's release focuses on AI package reliability: closing gaps in evaluation scoring, hardening OpenAI image-option handling, and removing the deprecated OpenAI Assistants API support.
Experimental API Changes
Removed Experimental APIs
OPENAI001) #7724What's Changed
AI
AI Evaluation
Repository Infrastructure Updates
Acknowledgements
Full Changelog: dotnet/extensions@v10.9.0...v10.10.0
Commits viewable in compare view.
Updated Microsoft.Extensions.Configuration.Abstractions from 10.0.11 to 10.0.12.
Release notes
Sourced from Microsoft.Extensions.Configuration.Abstractions's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.Extensions.DependencyInjection.Abstractions from 10.0.11 to 10.0.12.
Release notes
Sourced from Microsoft.Extensions.DependencyInjection.Abstractions's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.Extensions.FileSystemGlobbing from 10.0.11 to 10.0.12.
Release notes
Sourced from Microsoft.Extensions.FileSystemGlobbing's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.Extensions.Logging.Abstractions from 10.0.11 to 10.0.12.
Release notes
Sourced from Microsoft.Extensions.Logging.Abstractions's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.Extensions.Options from 10.0.11 to 10.0.12.
Release notes
Sourced from Microsoft.Extensions.Options's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Nerdbank.GitVersioning from 3.10.91 to 3.10.94.
Release notes
Sourced from Nerdbank.GitVersioning's releases.
3.10.94
What's Changed
Full Changelog: dotnet/Nerdbank.GitVersioning@v3.10.91...v3.10.94
Commits viewable in compare view.
Updated Oracle.ManagedDataAccess.Core from 23.26.300 to 23.26.301.
Updated Soenneker.Extensions.Enumerable from 4.0.649 to 4.0.667.
Release notes
Sourced from Soenneker.Extensions.Enumerable's releases.
4.0.667
Updated NuGet packages
4.0.666
Update dependency dotnet-sdk to v10.0.401 (#765)
4.0.665
Update dependency Soenneker.Utils.Random to 4.0.133 (#764)
4.0.664
Update dependency Soenneker.Extensions.ValueTask to 4.0.122 (#761)
4.0.663
Update dependency Soenneker.Extensions.Task to 4.0.129 (#760)
4.0.662
Use NuGet trusted publishing in publishing workflows
4.0.661
Updated Soenneker.Utils.Random to 4.0.131
4.0.660
Update dependency Soenneker.Extensions.ValueTask to 4.0.121 (#757)
4.0.659
Merge remote updates with performance improvements
4.0.658
Update dependency Soenneker.Utils.Random to 4.0.130 (#752)
4.0.657
Update dependency Soenneker.Extensions.ValueTask to 4.0.120 (#751)
4.0.656
Update dependency Soenneker.Extensions.Task to 4.0.128 (#750)
4.0.655
Rewrite enumerable usage documentation
4.0.654
Update dependency Soenneker.Extensions.ValueTask to 4.0.119 (#746)
4.0.653
Update dependency Soenneker.Utils.Random to 4.0.129 (#747)
4.0.652
Update dependency Soenneker.Extensions.Task to 4.0.127 (#745)
4.0.651
Improve XML documentation
4.0.650
Update dependency Soenneker.Extensions.Task to 4.0.126 (#744)
Commits viewable in compare view.
Updated Soenneker.Extensions.Enumerable.String from 4.0.1410 to 4.0.1461.
Release notes
Sourced from Soenneker.Extensions.Enumerable.String's releases.
4.0.1461
Updated NuGet packages
4.0.1460
Update dependency Soenneker.Extensions.String to 4.0.761 (#1955)
4.0.1459
Updated NuGet packages
4.0.1458
Update dependency dotnet-sdk to v10.0.401 (#1953)
4.0.1457
Update dependency Soenneker.Extensions.Enumerable to 4.0.666 (#1954)
4.0.1456
Update dependency Soenneker.Extensions.String to 4.0.753 (#1951)
4.0.1455
Updated Multiple NuGet packages
4.0.1454
Update dependency Soenneker.Extensions.Spans.ReadOnly.Strings to 4.0.36 (#1950)
4.0.1453
Update dependency Soenneker.Extensions.String to 4.0.752 (#1949)
4.0.1451
Update dependency Soenneker.Extensions.String to 4.0.750 (#1946)
4.0.1450
Update dependency Soenneker.Extensions.Spans.ReadOnly.Strings to 4.0.35 (#1932)
4.0.1449
Update dependency Soenneker.Extensions.String to 4.0.748 (#1942)
4.0.1447
Update dependency Soenneker.Extensions.Enumerable to 4.0.662 (#1939)
4.0.1445
Use NuGet trusted publishing in publishing workflows
4.0.1444
Update dependency Soenneker.Extensions.String to 4.0.745 (#1937)
4.0.1443
Updated Multiple NuGet packages
4.0.1442
Updated Multiple NuGet packages
4.0.1441
Updated Soenneker.Extensions.String to 4.0.743
4.0.1440
Update dependency Soenneker.Extensions.String to 4.0.742 (#1935)
4.0.1437
Update dependency Soenneker.Extensions.String to 4.0.740 (#1933)
4.0.1436
Update dependency Soenneker.Extensions.Enumerable to 4.0.660 (#1931)
4.0.1435
Merge remote updates with performance improvements
4.0.1434
Update dependency Soenneker.Extensions.String to 4.0.739 (#1922)
4.0.1433
Updated Soenneker.Extensions.String to 4.0.738
4.0.1432
Updated Soenneker.Extensions.String to 4.0.737
4.0.1431
Update dependency Soenneker.Extensions.String to 4.0.736 (#1910)
4.0.1430
Updated NuGet packages
4.0.1429
Update dependency Soenneker.Extensions.String to 4.0.734 (#1908)
4.0.1428
Update dependency Soenneker.Extensions.String to 4.0.733 (#1906)
4.0.1426
Update dependency Soenneker.Extensions.Enumerable to 4.0.657 (#1903)
4.0.1425
Update dependency Soenneker.Extensions.String to 4.0.732 (#1899)
4.0.1423
Update dependency Soenneker.Extensions.Spans.ReadOnly.Strings to 4.0.32 (#1898)
4.0.1422
Update dependency Soenneker.Extensions.Spans.ReadOnly.Strings to 4.0.28 (#1885)
4.0.1421
Update dependency Soenneker.Extensions.String to 4.0.729 (#1895)
4.0.1419
Rewrite string enumerable usage documentation
4.0.1418
Update dependency Soenneker.Extensions.String to 4.0.728 (#1892)
4.0.1416
Update dependency Soenneker.Extensions.String to 4.0.727 (#1889)
4.0.1414
Update dependency Soenneker.Extensions.Enumerable to 4.0.651 (#1884)
4.0.1413
Update dependency Soenneker.Extensions.String to 4.0.726 (#1886)
4.0.1412
Improve XML documentation
4.0.1411
Improve README documentation
Commits viewable in compare view.
Updated Soenneker.Extensions.String from 4.0.723 to 4.0.762.
Release notes
Sourced from Soenneker.Extensions.String's releases.
4.0.762
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.124 (#924)
4.0.761
Updated NuGet packages
4.0.760
Update dependency Soenneker.Culture.English.US to 4.0.52 (#921)
4.0.758
Document ReplaceMatches performance and semantics
4.0.753
Update dependency Soenneker.Utils.Random to 4.0.133 (#919)
4.0.752
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.121 (#918)
4.0.751
Optimize string hot paths and add reproducible performance audit
4.0.750
Updated Soenneker.Extensions.Spans.Readonly.Chars to 4.0.120
4.0.748
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.117 (#913)
4.0.747
Update dependency Soenneker.Culture.English.US to 4.0.51 (#912)
4.0.746
Use NuGet trusted publishing in publishing workflows
4.0.745
Updated Soenneker.Extensions.Spans.Readonly.Chars to 4.0.116
4.0.744
Updated Soenneker.Utils.Random to 4.0.131
4.0.743
Updated Multiple NuGet packages
4.0.742
Updated Soenneker.Extensions.Spans.Readonly.Chars to 4.0.114
4.0.741
Updated Multiple NuGet packages
4.0.740
Improves performance and allocation
4.0.739
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.112 (#905)
4.0.738
Updated Soenneker.Extensions.Spans.Readonly.Chars to 4.0.111
4.0.737
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.110 (#901)
4.0.736
Updated NuGet packages
4.0.735
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.108 (#900)
4.0.734
Update dependency Soenneker.Utils.Random to 4.0.130 (#899)
4.0.733
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.107 (#897)
4.0.732
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.105 (#896)
4.0.731
Clear Base64 buffers and narrow charset fallback
4.0.729
Update dependency Soenneker.Culture.English.US to 4.0.50 (#894)
4.0.728
Update dependency Soenneker.Utils.Random to 4.0.129 (#893)
4.0.727
Rewrite README with practical API guidance
4.0.726
Improve XML documentation
4.0.725
Update dependency Soenneker.Extensions.Spans.Readonly.Chars to 4.0.101 (#890)
4.0.724
Improve README documentation
Commits viewable in compare view.
Updated SonarAnalyzer.CSharp from 10.32.0.713 to 10.34.0.3385.
Release notes
Sourced from SonarAnalyzer.CSharp's releases.
10.34.0.3385
Release notes - .NET Analyzers - 10.34
Feature
NET-4133 Implement rule S9023: "Include" calls discarded by query reshaping should be fixed
False Positive
NET-3281 Fix S1192 FP: should not raise on DBContext model configuration
NET-4317 Fix S2325 FP: Do not raise on ConfigureServices in classes decorated with [LambdaStartup]
NET-4419 Fix S2737 FP: Do not report known temporary-context rethrow boundaries
NET-4421 Fix S6607 FP: Indexed LINQ Where after OrderBy
NET-4463 Fix S8747 FP: Do not raise when a defaultValue backfills existing NULLs before narrowing to non-nullable
NET-4506 Fix S6967 FP: Recognize manual DataAnnotations validation
NET-4507 Fix S8969 FP: Don't raise in Razor files
False Negative
NET-1883 Files added as symbolic links are not analyzed
NET-4249 Fix S9022 FN: Include before a terminal aggregate/scalar operator not detected as dead code
NET-4379 Fix S2259 FN: void compound assignment operators not flagged as dereference
NET-4383 Fix S9022 FN: Include on a navigation re-projected directly by a later Select/SelectMany is not detected as redundant
NET-4443 Fix S2068 FN: Scope the value passed to the secret-exclusion classifier to the candidate secret
NET-4496 Fix S8949 FN: self-recursion suppression also hides calls already recursive before the suggested fix
NET-4500 Fix S9022 FN: ThenInclude consumed only through a nested Select's rebound element parameter is not detected as redundant
Bug
NET-4483 Fix S3459 FP: Public writable properties in private nested types
Maintenance
NET-4472 Remove S1264 from the C# Sonar way profile
NET-4474 Remove S2692 from the C# Sonar way profile
NET-4480 Remove S3249 from the C# Sonar way profile
NET-4481 Remove S6670 from the C# Sonar way profile
NET-4482 Remove S3885 from the C# Sonar way profile
10.33.0.1635
Release notes - .NET Analyzers - 10.33
Feature
NET-4312 Update RSPEC before 10.33 release
NET-4254 Implement rule S9129: "Include" and "ThenInclude" chains of reference navigations should be merged into a single "Include" call
False Positive
NET-1777 Fix S101 FP: Lower case character after number
NET-4245 Fix S107 FP: should not raise for parameters marked with dependency-injection attributes
Maintenance
NET-4184 Duplicate telemetry key exception when multiple projects report the same non-counter telemetry value
Commits viewable in compare view.
Updated TUnit from 1.65.63 to 1.68.4.
Release notes
Sourced from TUnit's releases.
1.68.4
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.68.0...v1.68.4
1.68.0
What's Changed
Other Changes
Dependencies
New Contributors
Full Changelog: thomhurst/TUnit@v1.67.0...v1.68.0
1.67.0
What's Changed
Other Changes
Dependencies
New Contributors
... (truncated)
1.66.27
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.66.16...v1.66.27
1.66.16
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.66.10...v1.66.16
1.66.10
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.66.8...v1.66.10
1.66.8
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.66.0...v1.66.8
1.66.0
What's Changed
Other Changes
Typeassignability assertions to evaluate represented type (notRuntimeType) by @thomhurst with @Copilot in FixTypeassignability assertions to evaluate represented type (notRuntimeType) thomhurst/TUnit#6711Dependencies
Full Changelog: thomhurst/TUnit@v1.65.68...v1.66.0
1.65.68
What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.65.63...v1.65.68
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions