Migration to wireshark 4.4.x #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Described [here](https://gitlab.com/wireshark/wireshark/-/commit/c19c9992093f024189e442994bfd953c7cce3b30) and [here](https://gitlab.com/wireshark/wireshark/-/commit/601bf39e6b2eaff9e77588ff1b1a8a987dad404d) There is a camke module that is unnecessary and frequently causes hard-to-debug issues during CMake's configure run. Additionally, it uses the Python imp module, which was removed in Python 3.12 (importlib has replacement functions since Python 3.4, but we don't need this, since we expect our modules to be inside our source tree.)
chore: add Changelog
Migration to wireshark 4.4.x [3/3]
Migration to wireshark 4.4.x [2/*]
Migration to wireshark 4.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series of three PRs that fixes #15, fixes #17, fixes #18 and closes #19.
A culmination of issues stemming from breaking api changed in newer releases of wireshark, as well and lack of portability on macOS. Windows remains untested for now. Thanks to @seffradev for the groundwork!
Details & motivations can be be found here:
amitrahman1026#1
amitrahman1026#2
amitrahman1026#3
An overall summary:
Added
Changed
tvb_get_guintXandtvb_get_gintXfunctions in the tvbuff API has been renamed totvb_get_uintXandtvb_get_intX(the GLib-style "g" has been removed). The old-style names have been deprecated.#[derive(Protocol)]will now correctly register dissector protocols with uniqueproto_register_xxxin line with breaking wireshark plugin API changes since release 4.2.xplugin_describe()will now be implemented to properly build a plugin since 4.2.x