forked from ghpr-asia/wsdf
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to wireshark 4.4.x [1/*] #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Described [here](https://gitlab.com/wireshark/wireshark/-/commit/c19c9992093f024189e442994bfd953c7cce3b30) and [here](https://gitlab.com/wireshark/wireshark/-/commit/601bf39e6b2eaff9e77588ff1b1a8a987dad404d) There is a camke module that is unnecessary and frequently causes hard-to-debug issues during CMake's configure run. Additionally, it uses the Python imp module, which was removed in Python 3.12 (importlib has replacement functions since Python 3.4, but we don't need this, since we expect our modules to be inside our source tree.)
amitrahman1026
force-pushed
the
amit/upgrade-ws
branch
from
October 23, 2024 02:20
312894c
to
9587757
Compare
This was referenced Oct 23, 2024
amitrahman1026
changed the title
fix: resolve build errors from buggy Cmake
fix: Migration to wireshark 4.4.x [1/*]
Oct 30, 2024
amitrahman1026
changed the title
fix: Migration to wireshark 4.4.x [1/*]
Migration to wireshark 4.4.x [1/*]
Oct 30, 2024
Migration to wireshark 4.4.x [3/3]
Migration to wireshark 4.4.x [2/*]
amitrahman1026
changed the title
Migration to wireshark 4.4.x [1/*]
Migration to wireshark 4.4.x
Nov 8, 2024
amitrahman1026
changed the title
Migration to wireshark 4.4.x
Migration to wireshark 4.4.x [1/*]
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Described here and here.
There is a cmake module that is unnecessary and frequently causes hard-to-debug issues during CMake's configure run
Additionally, it uses the Python imp module, which was removed in Python 3.12 (importlib has replacement functions since Python 3.4, but we don't need this, since we expect our modules to be inside our source tree.)
Alleviates some cross building issues because there isn't exactly a pinned version of wireshark in wsdf
build.rs
forepan-sys
crate that will propogate CMake errors.Coming up next:
Will be subsequently tracking in
Todo.txt
. Note: there are still outstanding fixes to be done before generated dissector plugins from wsdf will be working for newer versions.