Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to wireshark 4.4.x [1/*] #1

Merged
merged 34 commits into from
Nov 8, 2024
Merged

Migration to wireshark 4.4.x [1/*] #1

merged 34 commits into from
Nov 8, 2024

Conversation

amitrahman1026
Copy link
Owner

@amitrahman1026 amitrahman1026 commented Oct 23, 2024

Changes

  1. CMake related issues:
  • Described here and here.

  • There is a cmake module that is unnecessary and frequently causes hard-to-debug issues during CMake's configure run

  • Additionally, it uses the Python imp module, which was removed in Python 3.12 (importlib has replacement functions since Python 3.4, but we don't need this, since we expect our modules to be inside our source tree.)

  • Alleviates some cross building issues because there isn't exactly a pinned version of wireshark in wsdf

  1. Changes from @seffradev to fix deprecated glib integers to fixed width C99 integers that newer versions of wireshark use. Many thanks for the groundwork and direction!
  2. Improvements to build.rs for epan-sys crate that will propogate CMake errors.
  3. Some documentation improvements better reflecting what wsdf is.

Coming up next:

Will be subsequently tracking in Todo.txt. Note: there are still outstanding fixes to be done before generated dissector plugins from wsdf will be working for newer versions.

Create integration testing for wsdf generated plugins

    As of now, besides unit tests, theres not an end to end testing framework
    that will give a better outlook on parity of wsdf generated plugins and
    wireshark native plugin functionality.

    A good approach would be to either hook onto the test suite of wireshark.


Improve cross platform building and pin releases to wireshark versions

    There have been various issues of end users not being able to build, not
    being able to generate usable plugins. This is in part due to the building,
    in part due to api changes in plugin creation and unmanaged wireshark
    versions.

    We could really use some unification on the build system.

    1. The most pressing issue wrt to plugins would be related to supporting
    changes in plug in creation APIs since wireshark 4.2.x.

    2. Some of the API now uses C99 types instead of
    [GLib types](https://gitlab.com/wireshark/wireshark/-/issues/19116).
    Appropriate changes will need to be backported down to 4.2.x.

    On top of that, there should be a better way to decouple and allow for
    flexibility of the underlying wireshark system.

seffradev and others added 5 commits September 9, 2024 19:42
Described
[here](https://gitlab.com/wireshark/wireshark/-/commit/c19c9992093f024189e442994bfd953c7cce3b30)
and [here](https://gitlab.com/wireshark/wireshark/-/commit/601bf39e6b2eaff9e77588ff1b1a8a987dad404d)

There is a camke module that is unnecessary and frequently causes hard-to-debug
issues during CMake's configure run.

Additionally, it uses the Python imp module, which was removed
in Python 3.12 (importlib has replacement functions since Python 3.4,
but we don't need this, since we expect our modules to be inside
our source tree.)
@amitrahman1026 amitrahman1026 changed the title fix: resolve build errors from buggy Cmake fix: Migration to wireshark 4.4.x [1/*] Oct 30, 2024
@amitrahman1026 amitrahman1026 changed the title fix: Migration to wireshark 4.4.x [1/*] Migration to wireshark 4.4.x [1/*] Oct 30, 2024
@amitrahman1026 amitrahman1026 changed the title Migration to wireshark 4.4.x [1/*] Migration to wireshark 4.4.x Nov 8, 2024
@amitrahman1026 amitrahman1026 changed the title Migration to wireshark 4.4.x Migration to wireshark 4.4.x [1/*] Nov 8, 2024
@amitrahman1026 amitrahman1026 merged commit dc12281 into main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants