Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to wireshark 4.4.x [3/3] #5

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

amitrahman1026
Copy link
Owner

@amitrahman1026 amitrahman1026 commented Nov 8, 2024

From the perspective of the user, using this crate for the first time, should generate bindings.rs for their specific set up. They should not have to worry about getting their example plugins to compile. Also side note, wsdf should be called a plugin framework to be a little more accurate its utility.

Summary of changes

In terms of efficiency, it is reasonable to have pre generated bindings. However, this reduces portability and we should move to stop remove tracking for bindings.rs in this crate.

For ease of use, the first time cargo build is run, a fresh generation of bindings will be run, and user can continue to regenerate bindings.rs in subsequent build if they wish to with cargo --features bindgen

Portability scripts have added that will provide users a base to port wsdf generated plugins on macOS system as well.

Up next

  • Rebase in Jun Yi's big refactor
  • Remove tracking on bindings.rs
  • Integration testing hooks to ensure parity in generated plugins
  • Find a better solution to find system libwireshark and other dependencies, and about building wireshark from source. Scope of this crate should be aimed at providing plugin generation for system's existing wireshark
  • In light of that, I am considering restricting declaration of version type if we are trying to link against system install of wireshark because it can lead to incompatibility

@amitrahman1026 amitrahman1026 force-pushed the amit/upgrade-ws-2 branch 2 times, most recently from c6129b1 to abffc62 Compare November 8, 2024 07:53
@amitrahman1026 amitrahman1026 marked this pull request as ready for review November 8, 2024 08:05
@amitrahman1026 amitrahman1026 changed the title Migration to wireshark 4.4.x [3/*] Migration to wireshark 4.4.x [3/3] Nov 8, 2024
@amitrahman1026 amitrahman1026 merged commit 2c9cb40 into amit/upgrade-ws-1 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant