Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the perspective of the user, using this crate for the first time, should generate bindings.rs for their specific set up. They should not have to worry about getting their example plugins to compile. Also side note, wsdf should be called a plugin framework to be a little more accurate its utility.
Summary of changes
In terms of efficiency, it is reasonable to have pre generated bindings. However, this reduces portability and we should move to stop remove tracking for bindings.rs in this crate.
For ease of use, the first time
cargo build
is run, a fresh generation of bindings will be run, and user can continue to regenerate bindings.rs in subsequent build if they wish to withcargo --features bindgen
Portability scripts have added that will provide users a base to port wsdf generated plugins on macOS system as well.
Up next