Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zio-http #1216

Merged
merged 2 commits into from
Mar 1, 2022
Merged

chore: update zio-http #1216

merged 2 commits into from
Mar 1, 2022

Conversation

uryyyyyyy
Copy link
Contributor

zio-http API is changed between RC17 -> RC18.

@uryyyyyyy
Copy link
Contributor Author

sorry, we may need to wait for tapir's update softwaremill/tapir#1686

@ghostdogpr
Copy link
Owner

Yep, needs tapir update first but tapir tests showed a bug in zio-http so we probably need another release of zio-http.

@guizmaii
Copy link
Contributor

guizmaii commented Jan 4, 2022

The update has been merged in Tapir :)

@uryyyyyyy
Copy link
Contributor Author

thanks! I'll prepare for the new tapir version.

@uryyyyyyy
Copy link
Contributor Author

waiting this fix.
softwaremill/tapir#1781

@uryyyyyyy uryyyyyyy force-pushed the zhttp_rc18 branch 2 times, most recently from 2d1a5ab to e02a96b Compare January 28, 2022 22:49
@uryyyyyyy
Copy link
Contributor Author

@ghostdogpr PR updated. Is it ok to use tapir v0.20.0-M7 ?

@ghostdogpr
Copy link
Owner

@uryyyyyyy I'd prefer to wait for the next official tapir release rather than depending on a milestone version. Thanks for your work and the bug fix in tapir!

@uryyyyyyy
Copy link
Contributor Author

OK, then let's wait their release. It's OK to change my PR If I'll be busy.

Thanks for the great tool.

@guizmaii
Copy link
Contributor

This takes forever 😭

I will very soon need the static file server feature released in the latest zio-http version, already updated in the master branch of Tapir 😭

@ghostdogpr
Copy link
Owner

ghostdogpr commented Feb 24, 2022

This takes forever 😭

I will very soon need the static file server feature released in the latest zio-http version, already updated in the master branch of Tapir 😭

Yeah, they just did a M10 a few days ago. You can try asking Adam W, I did for 0.19 and he published it quite quickly after I asked.

@ghostdogpr
Copy link
Owner

Tapir 0.20.0 was just released ^^ With zio-http bumped to 1.0.0.0-RC25

@uryyyyyyy
Copy link
Contributor Author

ok, will try migration today.

@ghostdogpr
Copy link
Owner

@uryyyyyyy Added a dependency to tapir-sttp-client-ws-zio1 to fix the (last?) problem

@ghostdogpr
Copy link
Owner

It's green! Thanks @uryyyyyyy

@ghostdogpr ghostdogpr merged commit b537c4c into ghostdogpr:master Mar 1, 2022
@uryyyyyyy uryyyyyyy deleted the zhttp_rc18 branch March 1, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants