Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZHttpAdapter adapter does not allow compilation and does run with recent versions of ZHttp #1238

Closed
pmeheut opened this issue Jan 6, 2022 · 2 comments

Comments

@pmeheut
Copy link
Contributor

pmeheut commented Jan 6, 2022

In ZHttpAdapter.scala, definition of makeWebSocketService is:

 def makeWebSocketService[R <: Has[_], E]

The Has[_] prevents compilation in Scala 3 when passing a simple interpreter with no trait, no Has.

As far as I know, this is useless and not in the other http adapters.

BTW, the code runs compiles with ZHttp 1.0.0.0-RC21 but fails at runtime. Line 43, HttpApp.responseM should be replaced by Http.fromEffect as the HttpApp object does not exist anymore in recent versions of ZHttp.

@ghostdogpr
Copy link
Owner

The Has[_] constraint is indeed no longer necessary, I just opened #1241 to remove it.

ZIO Http still being in RC, the API is not stable and versions are not binary compatible. It means you have to use the same version that caliban is using (1.0.0.0-RC17). RC18 and RC19 had some bugs preventing the upgrade. RC21 should be usable and work is in progress in #1216, waiting for a release of Tapir.

@pmeheut
Copy link
Contributor Author

pmeheut commented Jan 6, 2022

Thanks.

@pmeheut pmeheut closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants