vendor: sync subprocess.h and drop local patches - #26808
Merged
ngxson merged 1 commit intoAug 10, 2026
Merged
Conversation
Upstream merged the Windows argument quoting fix, the NetBSD build fix and the chdir fallback for glibc older than 2.29, so pin the vendored copy to a commit that carries all three and remove the patch files along with the apply step in the sync script. The new pin also brings the exec error report on glibc older than 2.24 and the ENOSYS mapping to a dedicated error code. Both are additive and no caller inspects those values.
ngxson
approved these changes
Aug 9, 2026
Collaborator
|
I'm re-running windows tests to see if that was a random fail: https://github.com/ggml-org/llama.cpp/actions/runs/31316672780/job/93289903504 |
Collaborator
|
no idea if windows CI problem was related to this PR, can you double-check it @ServeurpersoCom ? |
Contributor
Author
|
It's not from this PR, I'll make a small fix in a separate PR to correct master : #26826 -> and I rebase all my PR (and this one) on top of this Shame the hosted Windows runners are already nested one level deep, so no Linux containers there and no Docker coverage on Windows CI; Linux runners still cover it though. |
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 12, 2026
Upstream merged the Windows argument quoting fix, the NetBSD build fix and the chdir fallback for glibc older than 2.29, so pin the vendored copy to a commit that carries all three and remove the patch files along with the apply step in the sync script. The new pin also brings the exec error report on glibc older than 2.24 and the ENOSYS mapping to a dedicated error code. Both are additive and no caller inspects those values.
brittlewis12
pushed a commit
to brittlewis12/llama.cpp
that referenced
this pull request
Aug 17, 2026
Upstream merged the Windows argument quoting fix, the NetBSD build fix and the chdir fallback for glibc older than 2.29, so pin the vendored copy to a commit that carries all three and remove the patch files along with the apply step in the sync script. The new pin also brings the exec error report on glibc older than 2.24 and the ENOSYS mapping to a dedicated error code. Both are additive and no caller inspects those values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The three patches applied locally in the previous vendor PR are now merged upstream, so this pins
vendor/sheredom/subprocess.hto9ce0d701and drops the patch files together with the apply step inscripts/sync_vendor.py. The script is back to its pre patching shape, with only the pin bumped.Additional information
The new pin also picks up three upstream fixes that were not part of the patch set: the
-std=c++2afallback for older compilers, the up front executable check on glibc older than 2.24 whereposix_spawncannot report an exec failure, andENOSYSmapped to a dedicatedsubprocess_error_not_supportedcode. All additive, and nothing in llama.cpp readssubprocess_error_*orSUBPROCESS_HAVE_CWD.Upstream references:
Checked locally: the vendored file is byte identical to the pinned raw URL, so
check-vendorstays green, andllama-serverrebuilds clean.Follow-up #26606
Requirements