vendor : apply patches for subprocess.h - #26606
Merged
Merged
Conversation
nikwen
approved these changes
Aug 5, 2026
nikwen
left a comment
nikwen
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
I reviewed the upstream PRs and they make sense to me except for one comment, but that comment shouldn't block this PR.
ServeurpersoCom
approved these changes
Aug 5, 2026
Contributor
|
Nice, I like the patching approach, straightforward and easy to drop later. |
ggerganov
approved these changes
Aug 5, 2026
Collaborator
Author
|
@nikwen thanks, if @ServeurpersoCom change it upstream, feel free to push a PR here to sync it back |
Contributor
sheredom/subprocess.h#101 |
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 12, 2026
brittlewis12
pushed a commit
to brittlewis12/llama.cpp
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Quite many patches upstream and we started to see user complain, so temporary apply them now (mostly trivial patches) and remove in the future
Requirements