Revert "ui: fix accessibility for hover-gated interactive elements as… - #25098
Merged
Conversation
ServeurpersoCom
approved these changes
Jun 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the prior UI accessibility-focused changes to reduce rendering overhead in the sidebar (multiple conversation rows each mounting tooltip/portal-heavy elements), with the intent to address the reported performance regression.
Changes:
- Reintroduces hover/focus-gated rendering for the conversation actions dropdown in the sidebar item.
- Switches the sidebar conversation row back to a single clickable wrapper element and adjusts hover/focus handlers accordingly.
- Removes
group-focus-withinvisibility behavior for hover-gated action affordances in two chat components.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tools/ui/src/lib/components/app/navigation/SidebarNavigation/SidebarNavigationConversationItem.svelte | Gates actions dropdown rendering behind hover/focus state and changes the row wrapper/event handling to reduce tooltip/portal churn. |
| tools/ui/src/lib/components/app/chat/ChatMessages/ChatMessage/ChatMessageUser/ChatMessageUserPending.svelte | Removes focus-within reveal for action buttons (now hover-only). |
| tools/ui/src/lib/components/app/chat/ChatAttachments/ChatAttachmentsList/ChatAttachmentsListItem/ChatAttachmentsListItemMcpPrompt.svelte | Removes focus-within reveal for the remove button (now hover-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+107
to
+112
| <button | ||
| class="group flex min-h-9 w-full cursor-pointer items-center justify-between space-x-3 rounded-lg py-1.5 text-left transition-colors hover:bg-foreground/10 {isActive | ||
| ? 'bg-foreground/5 text-accent-foreground' | ||
| : ''} px-3" | ||
| onclick={handleSelect} | ||
| onmouseover={handleMouseOver} |
| <div | ||
| class="conversation-item group relative flex min-h-9 w-full items-center justify-between space-x-3 rounded-lg py-1.5 transition-colors hover:bg-foreground/10 {isActive | ||
| <!-- svelte-ignore a11y_mouse_events_have_key_events --> | ||
| <button |
| @@ -109,7 +130,7 @@ | |||
| <a | |||
| onclick={handleStop} | ||
| onkeydown={(e) => e.key === 'Enter' && handleStop(e)} |
| @@ -56,7 +56,7 @@ | |||
| <div class="relative flex h-6 items-center justify-between"> | |||
| <div class="right-0 flex items-center gap-2 opacity-100 transition-opacity"> | |||
| <div | |||
| class="pointer-events-auto inset-0 flex items-center gap-1 opacity-0 transition-all duration-150 group-focus-within:opacity-100 group-hover:opacity-100" | |||
| class="pointer-events-auto inset-0 flex items-center gap-1 opacity-0 transition-all duration-150 group-hover:opacity-100" | |||
Comment on lines
35
to
37
| <div | ||
| class="absolute top-10 right-2 flex items-center justify-center opacity-0 transition-opacity group-focus-within:opacity-100 group-hover:opacity-100" | ||
| class="absolute top-10 right-2 flex items-center justify-center opacity-0 transition-opacity group-hover:opacity-100" | ||
| > |
ggerganov
approved these changes
Jun 28, 2026
allozaur
force-pushed
the
fix/revert-24727
branch
2 times, most recently
from
June 28, 2026 14:00
405a109 to
1e59767
Compare
…sisted by claude(in debugging and tests) (ggml-org#24727)" This reverts commit ded1561.
allozaur
force-pushed
the
fix/revert-24727
branch
from
June 28, 2026 15:00
1e59767 to
b87d842
Compare
turbo-tan
pushed a commit
to turbo-tan/llama.cpp-tq3
that referenced
this pull request
Jul 1, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting #24727 that unfortunately introduced redering performance issue in case of multiple conversations in the sidebar and each of them rendering their own tooltips and portals.
This particular a11y challenge needs to be solved differently.