ui: fix accessibility for hover-gated interactive elements assisted b… - #24727
Merged
ServeurpersoCom merged 1 commit intoJun 26, 2026
Merged
Conversation
Contributor
Author
|
@allozaur can you correct me if there is any problem with this PR |
Contributor
Nothing at all, I plan to review it soon and potentially merge into my current improvements for overall UI |
Contributor
|
Should be rebased once #24897 is merged |
Contributor
Author
|
@allozaur sure let me know once the major ui fix pr is done |
Contributor
|
@sanjayahari let's go, #24897 is merged :) |
…y claude(in debugging and tests)
sanjayahari
force-pushed
the
ui/conversation-menu-accessibility
branch
from
June 24, 2026 09:00
f878ead to
8731a0e
Compare
Contributor
Author
|
@allozaur Okay , I am done with rebasing and other local stuff that created some mess but now ready to go |
allozaur
approved these changes
Jun 26, 2026
ServeurpersoCom
approved these changes
Jun 26, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, keyboard navigation tested on my side (Firefox) focus-within reveal works as expected
allozaur
added a commit
to allozaur/llama.cpp
that referenced
this pull request
Jun 28, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" This reverts commit ded1561.
turbo-tan
pushed a commit
to turbo-tan/llama.cpp-tq3
that referenced
this pull request
Jul 1, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
…y claude(in debugging and tests) (ggml-org#24727)
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
…y claude(in debugging and tests) (ggml-org#24727)
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
…sisted by claude(in debugging and tests) (ggml-org#24727)" (ggml-org#25098)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y claude(in debugging and tests)
Overview
#24701
I investigated the code in SidebarNavigationConversationItem.svelte
The root cause - two problems:
the actions dropdown (Delete, Edit, etc.) is conditionally removed from the DOM via {#if renderActionsDropdown}, so screen readers never see it
the outer element is a with nested interactive elements inside (links, buttons) which is invalid HTML
what fix i have done :
replaced the outer
with a
always render the dropdown in the DOM, use CSS opacity to hide/show it (which is already partially there bcz opacity is 0)
added :focus-within alongside every :hover rule so keyboard navigation works
I also found 2 other components missing group-focus-within:opacity-100 alongside group-hover:opacity-100:
ChatAttachmentsListItemMcpPrompt.svelte
ChatMessageUserPending.svelte
Additional information
Requirements