Skip to content

common : fix env names to all have LLAMA_ARG_ prefix#23778

Merged
ggerganov merged 1 commit into
masterfrom
gg/common-fix-env-args
May 27, 2026
Merged

common : fix env names to all have LLAMA_ARG_ prefix#23778
ggerganov merged 1 commit into
masterfrom
gg/common-fix-env-args

Conversation

@ggerganov
Copy link
Copy Markdown
Member

Overview

For consistency, make all env arguments have the same prefix: LLAMA_ARG_

Requirements

@ggerganov ggerganov requested review from a team and ngxson as code owners May 27, 2026 11:26
@github-actions github-actions Bot added documentation Improvements or additions to documentation examples devops improvements to build systems and github actions server labels May 27, 2026
@CISC
Copy link
Copy Markdown
Member

CISC commented May 27, 2026

Does this count as an API change? :) I imagine this might affect someone downstream.

@ggerganov ggerganov added the breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. label May 27, 2026
@ggerganov
Copy link
Copy Markdown
Member Author

Yes, updated the changelog.

@ggerganov ggerganov merged commit 6b4e4bd into master May 27, 2026
61 of 62 checks passed
@ggerganov ggerganov deleted the gg/common-fix-env-args branch May 27, 2026 11:52
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request May 27, 2026
* origin/master:
hexagon: add support for Q4_1 in MUL_MAT and MUL_MAT_ID (ggml-org#23647)
ggml-webgpu: Fix how to dispatch WG to some ops (ggml-org#23750)
vulkan: Switch MUL_MAT_VEC to 4 K per iteration for F16/32 (ggml-org#22887)
vulkan: use GL_NV_cooperative_matrix_decode_vector for faster matmul (ggml-org#23541)
vulkan: add REPEAT op support for f16 to f16. (ggml-org#23298)
ci : move ARM jobs to self-hosted + disable kleidiai mac release (ggml-org#23780)
vendor : update cpp-httplib to 0.46.0 (ggml-org#23650)
pyproject : add conversion folder and update dependencies (ggml-org#23746)
CUDA: restrict PDL to CTK >= 12.3 due to MSVC issues (ggml-org#23742)
ci : bump cuda release to 13.3 (ggml-org#23749)
common : fix env names to all have LLAMA_ARG_ prefix (ggml-org#23778)
ci : fix windows ccaches (ggml-org#23777)
ci : remove wasm test (ggml-org#23733)
vulkan: avoid preferring transfer queue on AMD UMA devices (ggml-org#22455)
ci : add ccache to server builds + fix undefined sanitizer build (ggml-org#23763)
docs : fix duplicated "the" in granitevision and model-conversion docs (ggml-org#23767)
convert: add MiniCPM5 tokenizer support (ggml-org#23384)
server : fix the log message when using SSL (ggml-org#23393)
LogicDaemon pushed a commit to LogicDaemon/llama-cpp-turboquant that referenced this pull request May 27, 2026
fewtarius pushed a commit to fewtarius/llama.cpp that referenced this pull request May 30, 2026
@pnb
Copy link
Copy Markdown
Contributor

pnb commented Jun 1, 2026

Was it intentional to leave the API key out of this, since it would be a really breaking change? It looks like it is the odd one out now.

turbo-tan pushed a commit to turbo-tan/llama.cpp-tq3 that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. devops improvements to build systems and github actions documentation Improvements or additions to documentation examples server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants