Skip to content

ci : remove wasm test#23733

Merged
ggerganov merged 2 commits into
masterfrom
cisc/ci-wasm-test-build
May 27, 2026
Merged

ci : remove wasm test#23733
ggerganov merged 2 commits into
masterfrom
cisc/ci-wasm-test-build

Conversation

@CISC
Copy link
Copy Markdown
Member

@CISC CISC commented May 26, 2026 •
edited
Loading

Overview

cont #23718

Requirements

@CISC CISC requested a review from a team as a code owner May 26, 2026 16:41
@CISC CISC changed the title ci : run tests in correct build folder ci : run wasm tests in correct build folder May 26, 2026
@github-actions github-actions Bot added the devops improvements to build systems and github actions label May 26, 2026
@CISC
Copy link
Copy Markdown
Member Author

CISC commented May 26, 2026

LOL
https://github.com/ggml-org/llama.cpp/actions/runs/26461898320/job/77911689415?pr=23733

@CISC
Copy link
Copy Markdown
Member Author

CISC commented May 26, 2026

@reeselevine Know what the [permission denied] is about?
https://github.com/ggml-org/llama.cpp/actions/runs/26461898320/job/77911689415?pr=23733#step:7:1256

@ggerganov
Copy link
Copy Markdown
Member

ggerganov commented May 26, 2026

I think it's ok to merge and resolve from master.

@CISC
Copy link
Copy Markdown
Member Author

CISC commented May 26, 2026

My guess though is that the tests aren't going to work anyway.

@CISC CISC changed the title ci : run wasm tests in correct build folder ci : remove wasm test May 26, 2026
@reeselevine
Copy link
Copy Markdown
Contributor

reeselevine commented May 26, 2026

sorry not sure I have the full context here. It seems like based on #23718 the CI didn't need the Vulkan SDK?

The reason that I set it up with the Vulkan SDK originally is that WebGPU does need a Vulkan installation to run on Linux systems, so I thought installing the Vulkan SDK was necessary. But maybe I'm misunderstanding how Vulkan is installed on these systems?

And the idea behind the WASM CI is not to actually run the tests, but to ensure that llama.cpp compiles via Emscripten, since that's necessary for running llama.cpp in the browser. So it seems like we shouldn't have added the Test block in #23718.

@CISC
Copy link
Copy Markdown
Member Author

CISC commented May 27, 2026

gentle ping if someone can either merge or reapprove :)

@ggerganov ggerganov merged commit b3a739c into master May 27, 2026
3 of 6 checks passed
@ggerganov ggerganov deleted the cisc/ci-wasm-test-build branch May 27, 2026 10:11
@reeselevine reeselevine mentioned this pull request May 27, 2026
Merged
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request May 27, 2026
@gabe-l-hart
Merge remote-tracking branch 'origin/master' into Granite4Vision
43a6f6e 
* origin/master:
hexagon: add support for Q4_1 in MUL_MAT and MUL_MAT_ID (ggml-org#23647)
ggml-webgpu: Fix how to dispatch WG to some ops (ggml-org#23750)
vulkan: Switch MUL_MAT_VEC to 4 K per iteration for F16/32 (ggml-org#22887)
vulkan: use GL_NV_cooperative_matrix_decode_vector for faster matmul (ggml-org#23541)
vulkan: add REPEAT op support for f16 to f16. (ggml-org#23298)
ci : move ARM jobs to self-hosted + disable kleidiai mac release (ggml-org#23780)
vendor : update cpp-httplib to 0.46.0 (ggml-org#23650)
pyproject : add conversion folder and update dependencies (ggml-org#23746)
CUDA: restrict PDL to CTK >= 12.3 due to MSVC issues (ggml-org#23742)
ci : bump cuda release to 13.3 (ggml-org#23749)
common : fix env names to all have LLAMA_ARG_ prefix (ggml-org#23778)
ci : fix windows ccaches (ggml-org#23777)
ci : remove wasm test (ggml-org#23733)
vulkan: avoid preferring transfer queue on AMD UMA devices (ggml-org#22455)
ci : add ccache to server builds + fix undefined sanitizer build (ggml-org#23763)
docs : fix duplicated "the" in granitevision and model-conversion docs (ggml-org#23767)
convert: add MiniCPM5 tokenizer support (ggml-org#23384)
server : fix the log message when using SSL (ggml-org#23393)
fewtarius pushed a commit to fewtarius/llama.cpp that referenced this pull request May 30, 2026
@CISC
ci : remove wasm test (ggml-org#23733)
202b175 
* run tests in correct build folder

* remove wasm test
turbo-tan pushed a commit to turbo-tan/llama.cpp-tq3 that referenced this pull request Jun 2, 2026
@CISC @charpdev
ci : remove wasm test (ggml-org#23733)
5a2c7ab 
* run tests in correct build folder

* remove wasm test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbev danbev danbev approved these changes

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

devops improvements to build systems and github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CISC @ggerganov @reeselevine @danbev