Skip to content

removed unecesary mmproj download when users pass --no-mmproj #23425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 2 commits into from
Jun 3, 2026
+5 −5
Merged

removed unecesary mmproj download when users pass --no-mmproj #23425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08d2a9
removed unecesary mmproj download when users pass --no-mmproj
ryan-mangeno May 20, 2026
df076ef
merge and new fix for setting download_mmproj flag, it is now being s…
ryan-mangeno May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions common/arg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ static handle_model_result common_params_handle_model(struct common_params_model
model.path = "";
}
common_download_opts hf_opts = opts;
hf_opts.download_mmproj = true; // also look for mmproj when downloading hf model
auto download_result = common_download_model(model, hf_opts);

if (download_result.model_path.empty()) {
Expand Down Expand Up @@ -441,10 +440,11 @@ bool common_params_handle_models(common_params & params, llama_example curr_ex)
COMMON_SPECULATIVE_TYPE_DRAFT_MTP) != params.speculative.types.end();

common_download_opts opts;
opts.bearer_token = params.hf_token;
opts.offline = params.offline;
opts.skip_download = params.skip_download;
opts.download_mtp = spec_type_draft_mtp;
opts.bearer_token = params.hf_token;
opts.offline = params.offline;
opts.skip_download = params.skip_download;
opts.download_mtp = spec_type_draft_mtp;
opts.download_mmproj = !params.no_mmproj;

try {
auto res = common_params_handle_model(params.model, opts);
Expand Down