removed unecesary mmproj download when users pass --no-mmproj#23425
Merged
Conversation
…et from params.no_mmproj
Contributor
Author
|
the bug still exists in latest release tag thanks to @jerkstorecaller for mentioning it and my recent changes seems to fix #23265 (comment) |
ggerganov
approved these changes
Jun 1, 2026
ggerganov
added
the
merge ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When --no-mmproj is passed the mmproj file is still being downloaded before the flag was checked. The flag was only used to clear params.mmproj after the download already completed. Also .. in common/arg.cpp the download_mmproj flag in
common_download_modelwas hardcoded to true.The fix uses the no_mmproj bool in the common_params struct when
common_params_handle_modelis calledAdditional information
Fixes #23265
Requirements