ui: prevent checkbox click from propagating in tools submenu#23276
ui: prevent checkbox click from propagating in tools submenu#23276MaxKruse wants to merge 3 commits into
Conversation
Hmm, will see into this and get back to you. |
allozaur
left a comment
There was a problem hiding this comment.
okay, so as a short term solution let's merge your fix, but please add a todo comment that this needs to be revisited and investigated in the future and make sure that the comment includes todo and hack words
|
@allozaur Should be good to go, apologies for no deeper analysis on my part as to why this seems broken 😔 |
np, @ServeurpersoCom i will pass this one to you to handle as u have Windows machine at hand |
|
I think we need to refactor the logic of this tool selector (the design is already clean, and I'm doing the logic first) plus we don't need to bother with a migration since it's quick to configure. Also to fix #22796 |
oki, so i guess we can close this PR once your supersedes it? @ServeurpersoCom |
Yes, it's better to tackle the root cause. |
Overview
Fixes #22796
Additional information
I have absolutely no idea why preventing propagation onclick for the Checkbox fixes the issue. Frontend logic is beyond me. But a fix is a fix
Requirements