Skip to content

ui: prevent checkbox click from propagating in tools submenu#23276

Closed
MaxKruse wants to merge 3 commits into
ggml-org:masterfrom
MaxKruse:fix/tool-checkbox-state
Closed

ui: prevent checkbox click from propagating in tools submenu#23276
MaxKruse wants to merge 3 commits into
ggml-org:masterfrom
MaxKruse:fix/tool-checkbox-state

Conversation

@MaxKruse
Copy link
Copy Markdown

Overview

Fixes #22796

Additional information

I have absolutely no idea why preventing propagation onclick for the Checkbox fixes the issue. Frontend logic is beyond me. But a fix is a fix

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES. Had Qwen3.5 122b try to figure out whats going on exactly, then checked myself to see if there was another reason for the bug - as far as i can tell, there wasnt.

@MaxKruse MaxKruse requested a review from a team as a code owner May 18, 2026 13:45
@allozaur
Copy link
Copy Markdown
Contributor

I have absolutely no idea why preventing propagation onclick for the Checkbox fixes the issue. Frontend logic is beyond me. But a fix is a fix

Hmm, will see into this and get back to you.

Copy link
Copy Markdown
Contributor

@allozaur allozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, so as a short term solution let's merge your fix, but please add a todo comment that this needs to be revisited and investigated in the future and make sure that the comment includes todo and hack words

@MaxKruse
Copy link
Copy Markdown
Author

MaxKruse commented Jun 2, 2026

@allozaur Should be good to go, apologies for no deeper analysis on my part as to why this seems broken 😔

@allozaur
Copy link
Copy Markdown
Contributor

allozaur commented Jun 3, 2026

@allozaur Should be good to go, apologies for no deeper analysis on my part as to why this seems broken 😔

np, @ServeurpersoCom i will pass this one to you to handle as u have Windows machine at hand

@ServeurpersoCom
Copy link
Copy Markdown
Contributor

I think we need to refactor the logic of this tool selector (the design is already clean, and I'm doing the logic first) plus we don't need to bother with a migration since it's quick to configure. Also to fix #22796

@allozaur
Copy link
Copy Markdown
Contributor

allozaur commented Jun 3, 2026

I think we need to refactor the logic of this tool selector (the design is already clean, and I'm doing the logic first) plus we don't need to bother with a migration since it's quick to configure. Also to fix #22796

oki, so i guess we can close this PR once your supersedes it? @ServeurpersoCom

@ServeurpersoCom
Copy link
Copy Markdown
Contributor

I think we need to refactor the logic of this tool selector (the design is already clean, and I'm doing the logic first) plus we don't need to bother with a migration since it's quick to configure. Also to fix #22796

oki, so i guess we can close this PR once your supersedes it? @ServeurpersoCom

Yes, it's better to tackle the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: webui: Builtin-Tool selector not selecting correctly in all cases

3 participants