Skip to content

ui: prevent checkbox click from propagating in tools submenu #23276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxKruse wants to merge 3 commits into from
Closed

ui: prevent checkbox click from propagating in tools submenu #23276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef9afcb
fix: prevent checkbox click from propagating in tools submenu
MaxKruse May 18, 2026
1d787e6
Merge branch 'ggml-org:master' into fix/tool-checkbox-state
MaxKruse May 18, 2026
feb3f14
Add comment to investigate Checkbox onclick behavior at a later date
MaxKruse Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../app/chat/ChatForm/ChatFormActions/ChatFormActionAdd/ChatFormActionAddToolsSubmenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,11 @@
class="flex w-full items-center gap-2 rounded px-2 py-1.5 text-left text-sm transition-colors hover:bg-muted/50"
onclick={() => toolsStore.toggleTool(tool.function.name)}
>
<!-- TODO: Investigate why the stopPropagation hack is needed here and properly fix it. See https://github.com/ggml-org/llama.cpp/pull/23276#pullrequestreview-4411500890 and the linked issue for more details. -->
<Checkbox
checked={toolsStore.isToolEnabled(tool.function.name)}
onCheckedChange={() => toolsStore.toggleTool(tool.function.name)}
onclick={(e) => e.stopPropagation()}
class="h-4 w-4 shrink-0"
/>

Expand Down