CUDA: loop over ne2*ne3 in case it overflows#19538
Merged
am17an merged 2 commits intoggml-org:masterfrom Feb 13, 2026
Merged
Conversation
github-actions
bot
added
Nvidia GPU
ggml/src/ggml-cuda/convert.cu
Outdated
Comment on lines
+21
to
+22
| const int64_t i02 = i0203 % ne02; | ||
| const int64_t i03 = i0203 / ne02; |
Contributor
There was a problem hiding this comment.
Preferably use fastdiv here.
ggml/src/ggml-cuda/convert.cu
Outdated
Comment on lines
+632
to
+633
| const int64_t i02 = i0203 % ne02; | ||
| const int64_t i03 = i0203 / ne02; |
Contributor
|
Since this PR is a draft: is there something that is still missing? |
JohannesGaessler
approved these changes
Feb 12, 2026
ronaldmannak
pushed a commit
to PicoMLX/llama.cpp
that referenced
this pull request
Feb 16, 2026
* CUDA: loop over ne2*ne3 in case it overflows * use fastdiv (cherry picked from commit 5065da5)
liparetejas
pushed a commit
to liparetejas/llama.cpp
that referenced
this pull request
Feb 23, 2026
* CUDA: loop over ne2*ne3 in case it overflows * use fastdiv
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 2, 2026
* CUDA: loop over ne2*ne3 in case it overflows * use fastdiv
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
Mar 3, 2026
* CUDA: loop over ne2*ne3 in case it overflows * use fastdiv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.