Skip to content

test: mul_mat tests with huge batch size#19519

Merged
jeffbolznv merged 1 commit intoggml-org:masterfrom
jeffbolznv:test_mul_mat_huge_batch
Feb 20, 2026
Merged

test: mul_mat tests with huge batch size#19519
jeffbolznv merged 1 commit intoggml-org:masterfrom
jeffbolznv:test_mul_mat_huge_batch

Conversation

@jeffbolznv
Copy link
Contributor

tests for #19471.
vulkan fix is in #19509.

@github-actions github-actions bot added the testing Everything test related label Feb 11, 2026
@jeffbolznv
Copy link
Contributor Author

@reeselevine can you address the webgpu failure? @JohannesGaessler or @am17an can you address the cuda failure? For context, in #19471 with a larger -ub parameter the total batch size was more than 64k and overflowed the max workgroup count in the y or z dimension (in the vulkan backend).

@reeselevine
Copy link
Contributor

#19535 should fix the WebGPU failures

@am17an
Copy link
Contributor

am17an commented Feb 12, 2026

Are these only for the F16 data-type? For large batch sizes the CUDA code falls back to using cuBLAS, I think that should be a relatively simple change vs doing for quantized data types

@jeffbolznv
Copy link
Contributor Author

In the failing model, everything was GGML_TYPE_F32. The GGML_TYPE_F16 came from me copy/pasting another test case. We could add both if there's an interesting difference in the code paths.

@am17an
Copy link
Contributor

am17an commented Feb 12, 2026

as long as it's F16, BF16 or F32 I think #19538 will fix it (passes these tests)

@jeffbolznv jeffbolznv force-pushed the test_mul_mat_huge_batch branch from a3de448 to f6c10e6 Compare February 19, 2026 14:05
@jeffbolznv jeffbolznv merged commit 77d6ae4 into ggml-org:master Feb 20, 2026
77 of 78 checks passed
liparetejas pushed a commit to liparetejas/llama.cpp that referenced this pull request Feb 23, 2026
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 2, 2026
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants