Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#18426
Merged
am17an merged 1 commit intoggml-org:masterfrom Dec 28, 2025
Merged
Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#18426am17an merged 1 commit intoggml-org:masterfrom
am17an merged 1 commit intoggml-org:masterfrom
Conversation
…VE=ON (ggml-org#18413)" This reverts commit 4fd59e8.
github-actions
bot
added
Nvidia GPU
JohannesGaessler
approved these changes
Dec 28, 2025
Contributor
|
Maybe I should have clarified in the other PR: I used the phrasing "should be correct" because at the time that I wrote it I only did static code analysis but without testing whether the PR is accidentally breaking anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…VE=ON (#18413)"
This reverts commit 4fd59e8.
The reason is that fix is only for the Docker builds without GPU and breaks all native builds otherwise. We also cannot allow users to specify
120-realand expect compilation to work at the moment. For Docker builds without GPU the correct way would be to build without GGML_NATIVE